-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support DISABLE_NETWORK_RESOURCE_PROVISIONING #1586
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M00nF1sh
reviewed
Aug 26, 2021
M00nF1sh
reviewed
Aug 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
M00nF1sh
approved these changes
Aug 26, 2021
haouc
pushed a commit
to haouc/amazon-vpc-cni-k8s
that referenced
this pull request
Aug 31, 2021
* Support DISABLE_NETWORK_RESOURCE_PROVISIONING * Skip tagENI in reconciler * Prevent cleanup leaked ENI * fix up readme
haouc
pushed a commit
to haouc/amazon-vpc-cni-k8s
that referenced
this pull request
Aug 31, 2021
* Support DISABLE_NETWORK_RESOURCE_PROVISIONING * Skip tagENI in reconciler * Prevent cleanup leaked ENI * fix up readme
jayanthvn
added a commit
to jayanthvn/amazon-vpc-cni-k8s
that referenced
this pull request
Sep 11, 2021
jayanthvn
added a commit
that referenced
this pull request
Sep 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue does this PR fix:
Support DISABLE_NETWORK_RESOURCE_PROVISIONING
What does this PR do / Why do we need it:
Certain users doesn't want to attach
AmazonEKS_CNI_Policy
and make IPAMD behave like in a readonly mode. This toggle was added but never supported. This PR will avoid IPAMD to attach ENIs, IPs/prefixes, tag ENIs and refresh SGs if DISABLE_NETWORK_RESOURCE_PROVISIONING set to true.If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
n/a
Testing done on this change:
Yes
Startup ->
Manually Added an ENI ->
Added 2 IPs to the ENIs and coreDNS pods came up
Automation added to e2e:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.