Disable codecov on patch #1226
Merged
Disable codecov on patch #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogren
force-pushed
the
disable-codecov-patch
branch
from
a13ca36 to
f2c2cd8
Compare
This was referenced Sep 24, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
cleanup
Which issue does this PR fix:
Even a PR with 84% patch test coverage is so full of CodeCov warnings that it is hard to read.
Why do we need it:
Just renaming an existing function or variable makes CodeCov treat it as a patch missing coverage and fail the check. We want to have all checks green for PRs to be merged. Some other projects having the same issue: argoproj/argo-cd#1926, mozilla-mobile/firefox-tv#778, kata-containers/tests#508.
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Open a PR, look at the file changes.
Testing done on this change:
None
Automation added to e2e:
None
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.