Allow instance attributes to be provided from config file. #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another case of aws#732, instance attributes from the config file get overriden by the nil instance attributes from the environment.
ejholmes
force-pushed
the
instance-attributes
branch
from
8fbe440
to
7f3d187
Compare
|
@ejholmes Thank you!! Can you confirm that this contribution is licensed under the terms of the Apache 2.0 license? |
|
@petderek sorry about that! Update the PR description with the license. |
|
@ejholmes Could you respond "yes" after the colon in the template? Also, I'd like to make a few additional changes to the unit tests. I'll open another PR in addition to this one and carry your commit into it (assuming the license is squared away). Thank you! |
|
@petderek updated. |
|
Merged with #908 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically another case of #732, where instance attributes from the config file get overridden by the empty instance attributes from the environment.
I think the underlying problem was that
ZeroOrNilin theutilspackage didn't handle map's, so I fixed the issue there. Based ongit grep ZeroOrNilit looks like this wouldn't have any unintended side effects.Licensing
This contribution is under the terms of the Apache 2.0 License: yes