Adds config parameter to shared netlib platform #4421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoseVillalta
force-pushed
the
platform-config
branch
2 times, most recently
from
cbf17d5
to
9d33fed
Compare
hoshank10
reviewed
Nov 6, 2024
hoshank10
reviewed
Nov 6, 2024
| name string | ||
| resolvConfPath string | ||
| }{ | ||
| {name: "al", resolvConfPath: "/etc/resolv.conf"}, |
There was a problem hiding this comment.
should this be just /etc? I can see we are appending /resolv.conf to resolvConfPath in the test below
There was a problem hiding this comment.
Thanks for catching that.
JoseVillalta
force-pushed
the
platform-config
branch
from
9d33fed
to
a77d3d1
Compare
hoshank10
approved these changes
Nov 6, 2024
This was referenced Nov 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes Fargate Agent network configuration when running in ec2-debug mode on BottleRocket OS.
This unblocks end-to-end functional tests in internal Fargate Agent CI/CD pipeline.
Implementation details
Add configuration struct to shared netlib platform initializer. In order to support Fargate EC2 Debug mode in all platform types and OS combinations. Bottlerocket has a different path for the resolv.conf file
Testing
New tests cover the changes:
Yes. Created
TestCommon_CreateDNSFilesForDebuginecs-agent/netlib/platformDescription for the changelog
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
NO
Does this PR include the addition of new environment variables in the README?
NO
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.