Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ecs-init to aws-sdk-go-v2 #4372

Merged
merged 6 commits into from
Oct 21, 2024
Merged

Conversation

tinnywang
Copy link
Contributor

@tinnywang tinnywang commented Sep 30, 2024

Summary

Migrate the ecs-init module to aws-sdk-go-v2 because aws-sdk-go will reach end of support on July 31, 2025.

Implementation details

Testing

  • GitHub status checks pass.
  • Downloaded the ecs-init RPM/DEB packages built from this PR. Installed the packages on EC2 instances running AL2, AL2023, and Ubuntu. Verified that Agent started/stopped/restarted when the systemd ecs-init service was started/stopped/restarted.

New tests cover the changes: no

Description for the changelog

Migrate ecs-init to aws-sdk-go-v2.

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tinnywang tinnywang changed the base branch from master to dev September 30, 2024 20:58
@tinnywang tinnywang marked this pull request as ready for review October 2, 2024 00:30
@tinnywang tinnywang requested a review from a team as a code owner October 2, 2024 00:30
@@ -0,0 +1,76 @@
package awsrulesfn
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This go generate copies this AWS SDK file from vendor into our package.

@@ -0,0 +1,403 @@
// Code generated by endpoint/awsrulesfn/internal/partition. DO NOT EDIT.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This go generate copies this AWS SDK file from vendor into our package.

ecs-init/go.mod Outdated Show resolved Hide resolved
ecs-init/config/common.go Outdated Show resolved Hide resolved
Copy link
Contributor

@danehlim danehlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much for your work on this migration change!

@tinnywang tinnywang merged commit f7dfa32 into aws:dev Oct 21, 2024
40 checks passed
@tinnywang tinnywang deleted the aws-sdk-go-v2/ecs-init branch October 21, 2024 23:51
amogh09 pushed a commit to amogh09/amazon-ecs-agent that referenced this pull request Oct 23, 2024
@mye956 mye956 mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants