Check if nsenter is available and bind mount it on Agent container #4341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mye956
approved these changes
Sep 17, 2024
tinnywang
approved these changes
Sep 17, 2024
mye956
pushed a commit
to mye956/amazon-ecs-agent
that referenced
this pull request
Oct 3, 2024
mye956
pushed a commit
to mye956/amazon-ecs-agent
that referenced
this pull request
Oct 3, 2024
mye956
pushed a commit
that referenced
this pull request
Oct 3, 2024
harishxr
pushed a commit
that referenced
this pull request
Oct 7, 2024
harishxr
pushed a commit
to harishxr/amazon-ecs-agent
that referenced
this pull request
Oct 11, 2024
amogh09
added a commit
to amogh09/amazon-ecs-agent
that referenced
this pull request
Oct 21, 2024
amogh09
added a commit
that referenced
this pull request
Oct 25, 2024
mye956
pushed a commit
that referenced
this pull request
Oct 30, 2024
mye956
pushed a commit
that referenced
this pull request
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR make ecs-init look for
/usr/bin/nsenteron the container instance and creates a bind mount for it on Agent container if found. This tool is used by fault-injection feature.Testing
Tested with and without
/usr/bin/nsenteron the host.When it was not available then it was not bind mounted on the container and the following warning is seen.
When it was available then it was bind mounted on the Agent container.
New tests cover the changes: yes
Description for the changelog
Check if nsenter is available and bind mount it on Agent container for fault injection.
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.