UpdateDesiredStatus for task stop verification ACK #4240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaithal
reviewed
Jul 11, 2024
danehlim
force-pushed
the
update-desiredstatus
branch
from
47913d7
to
2f717d7
Compare
aaithal
approved these changes
Jul 11, 2024
yinyic
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update ECS Agent to update containers' (desired) statuses when stopping a task as part of responding to a task stop verification ACK received from ACS.
ECS Agent may not call
UpdateDesiredStatuswhen stopping tasks in response to task stop verification ACKs sent from ACS. Having ECS Agent perform this call is strictly necessary sinceUpdatedDesiredStatusis responsible for updating container statuses to STOPPED in this case.For supplementary information on when ACS may send a task stop verification ACK to ECS Agent, please refer to the original pull request for full task sync feature.
Implementation details
UpdateDesiredStatusafter setting desired status for the task here (refer to Summary above)AddTaskTesting
Manually test using a custom ECS Agent built with the changes in this pull request against an internal bug repro environment. With the custom ECS Agent, bug behavior is no longer observed.
New tests cover the changes: existing tests updated (additional verification of containers' desired statuses being updated when stopping a task in response to a task stop verification ACK)
Description for the changelog
UpdateDesiredStatus for task stop verification ACK
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.