Enable agent to detect FIPS enabled hosts #4189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
reviewed
May 23, 2024
sparrc
previously approved these changes
May 24, 2024
singholt
reviewed
May 24, 2024
singholt
reviewed
May 24, 2024
singholt
reviewed
May 24, 2024
sparrc
reviewed
May 24, 2024
singholt
approved these changes
May 24, 2024
sparrc
approved these changes
May 28, 2024
added 5 commits
May 28, 2024 10:53
Merged
saurabhc123
pushed a commit
to saurabhc123/amazon-ecs-agent
that referenced
this pull request
Jun 4, 2024
* Enable agent to detect FIPS enabled hosts * Add unit test for FIPS detection * Add FIPS detection stub function for Windows * Update unit test for FIPS detection * Adding fips_unsupported file, fixing build tags, adding additional logging --------- Co-authored-by: Harish Senthilkumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request enables ECS Agent on linux to detect if FIPS mode is enabled on the host machine and store the detected value.
Implementation details
DetectFIPSModein the utils package (utils/fips_linux.go). This function reads the/proc/sys/crypto/fips_enabledfile to check if FIPS mode is enabled.isFIPSEnabledin the config package (config.go), which is initialized during the package initialization using theIsFIPSEnabledfunction.DetectFIPSModein the utils package (utils/fips_windows.go). This function will setisFIPSEnabledtofalseby default on Windows hosts.Testing
New tests cover the changes: yes
Description for the changelog
Enable agent to detect FIPS enabled hosts
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.