Add restart count to TMDE v4 response #4166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
force-pushed
the
crp-tmde
branch
4 times, most recently
from
5ff0611
to
bc83af0
Compare
sparrc
force-pushed
the
crp-tmde
branch
23 times, most recently
from
4e9befe
to
1278ff3
Compare
sparrc
force-pushed
the
crp-tmde
branch
10 times, most recently
from
6db4637
to
0d00199
Compare
sparrc
changed the title
hozkaya2000
previously approved these changes
May 21, 2024
chienhanlin
reviewed
May 21, 2024
| if !ok { | ||
| // did not find container, continue on and try next container(s) | ||
| // we don't return error here to avoid disrupting all of a TMDS response | ||
| // on a single missing container. |
There was a problem hiding this comment.
Should we add a log at warning or debug level if the container cannot be found from the state?
Like https://github.com/aws/amazon-ecs-agent/blob/master/agent/handlers/v4/stats_response.go#L41-L46.
hozkaya2000
approved these changes
May 22, 2024
chienhanlin
approved these changes
May 22, 2024
sparrc
added a commit
that referenced
this pull request
Jun 26, 2024
* Add restart count to TMDE v4 response * Add warning log message if container is not found in internal state
sparrc
added a commit
that referenced
this pull request
Jul 29, 2024
* Add restart count to TMDE v4 response * Add warning log message if container is not found in internal state
sparrc
added a commit
that referenced
this pull request
Jul 29, 2024
* Add restart count to TMDE v4 response * Add warning log message if container is not found in internal state
sparrc
added a commit
that referenced
this pull request
Jul 29, 2024
* Add restart count to TMDE v4 response * Add warning log message if container is not found in internal state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update v4 TMDE with the restart count of the container, if the container has a restart policy enabled.
Testing
unit tests updated, manual check on restart count being incremented as expected
Description for the changelog
NA
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.