Implement regular ENI and branch ENI configuration #3972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the network builder and platform APIs into the shared library package.
samjkon
changed the title
Realmonia
reviewed
Oct 24, 2023
samjkon
changed the title
Realmonia
previously approved these changes
Oct 25, 2023
xxx0624
reviewed
Oct 30, 2023
xxx0624
reviewed
Oct 30, 2023
xxx0624
approved these changes
Nov 3, 2023
Realmonia
approved these changes
Nov 3, 2023
as14692
pushed a commit
to as14692/amazon-ecs-agent
that referenced
this pull request
Nov 6, 2023
This PR implements regular ENI and branch ENI configuration for the containerd platform including network namespace setup, DNS config file creation and CNI plugin execution. Additionally it includes many additional wrapper utilities and their corresponding mock files. --------- Co-authored-by: Samuel Konat <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements regular ENI and branch ENI configuration for the containerd platform including network namespace setup, DNS config file creation and CNI plugin execution. Additionally it includes many additional wrapper utilities and their corresponding mock files.
Implementation details
Changes in
NetworkBuilder:Startmethod for AWSVPC network mode.Changes in
ecs-agent/netlib/platformpackage:Changes in
ecs-agent/volumepackage:VolumeAccessoris introduced. This is mainly to allow copying files in to task volumes from the root volume. TheVolumeAccessoris agent specific, the concrete implementation is not included here. It will be done in the agent specific code during the integration phase.Changes in
ecs-agent/datapackage:NetworkDataClientfrom here and moved it to a new packageecs-agent/netlib/data.Changes in
ecs-agent/netlib/datapackage:Dependencies are updated in
go.modand the vendor directory to includehttps://github.com/vishvananda/netlinkto the list.Added copyright comment in several new and old files.
Testing
New tests cover the changes: Yes. Further integration tests will be added in subsequent PRs with dependent code.
Description for the changelog
Implement regular ENI and branch ENI configuration
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.