Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use float64 for network rate stats #3865

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

amogh09
Copy link
Contributor

@amogh09 amogh09 commented Aug 23, 2023

Summary

Changing the type of network rate stats RxBytesPerSecond and TxBytesPerSecond in ecs-agent module from float32 to float64 to match Fargate Agent.

The change in behavior for TMDS v4 is that network_rate_stats field in stats response will now have more precision.

Testing

Called TMDS v4 task stats endpoint. The results are shown below.
Before

{
  "rx_bytes_per_sec": 44802.4609375,
  "tx_bytes_per_sec": 119103.296875
}

After (only the precision is important, values from different tests won't match as a lot of factors determine the stats).

{
  "rx_bytes_per_sec": 44806.56,
  "tx_bytes_per_sec": 119114.195
}

New tests cover the changes: no

Description for the changelog

Use float64 for network rate stats

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@amogh09 amogh09 requested a review from a team as a code owner August 23, 2023 16:52
@amogh09 amogh09 changed the title Use float64 for network rate stats in TMDS Use float64 for network rate stats Aug 23, 2023
@amogh09 amogh09 merged commit 7a01038 into aws:dev Aug 23, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants