Use float64 for network rate stats #3865
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changing the type of network rate stats
RxBytesPerSecond
andTxBytesPerSecond
in ecs-agent module fromfloat32
tofloat64
to match Fargate Agent.The change in behavior for TMDS v4 is that
network_rate_stats
field in stats response will now have more precision.Testing
Called TMDS v4 task stats endpoint. The results are shown below.
Before
After (only the precision is important, values from different tests won't match as a lot of factors determine the stats).
New tests cover the changes: no
Description for the changelog
Use float64 for network rate stats
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.