-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EBS volume metrics collector daemon #3766
Conversation
164c953
to
6d984c3
Compare
ecs-agent/daemon_images/csi-driver/tarfiles/csi-driver-linux-amd64.tar
Outdated
Show resolved
Hide resolved
aa0a4b6
to
0ee049f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the supported flags are different
nit: Could we include what flags were added/removed/modified somewhere within the PR description?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the current implementation support file based logging via klog however the AWS ebs csi driver doesn't. The klog is the log lib used by the AWS ebs csi driver.
nit(non-blocking): this is a bit confusing to read at first, perhaps this could be reworded better to clarify whether or not klog is used by the AWS ebs csi driver?
Done.
Sure, updated. |
Summary
Implementation details
This daemon will host an unix socket based GRPC server which will implement one interface https://github.com/container-storage-interface/spec/blob/master/spec.md#nodegetvolumestats and can provide the capability for ECS Agent to get the volume stats for one given mounted EBS volume.
In this PR, it includes the GRPC server related logics only. And the implementation is same as the volume stats implementation of the existing AWS ebs csi driver implementation (https://github.com/kubernetes-sigs/aws-ebs-csi-driver/) except the following items -
how go.mod and go.sum are updated
go mod tidy
andgo mod vendor
in bothagent
dir andecs-agent
dir already.go.mod
are same as thego.mod
of agent.how to start up the process (won't work until one following PR is out)
Testing
New tests cover the changes: yes
Also
make test
under the new directory.Description for the changelog
Add the EBS volume metrics collector.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.