Add "more than one ECS failure" case to Task Protection TMDS tests #3749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… more than one failure
amogh09
changed the title
amogh09
changed the title
Realmonia
approved these changes
Jun 14, 2023
|
No I have not seen it. But since we have the logic I wanted to cover it in the tests to make sure that the TMDS refactoring work doesn't miss it. |
sparrc
approved these changes
Jun 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current TMDS-level tests for Task Protection endpoints do not cover the case when ECS Task Protection API call returns more than one failure. This PR updates the tests to cover that case.
Testing
New tests cover the changes: NA
Description for the changelog
Add "more than one ECS failure" case to Task Protection TMDS tests
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.