Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move eventstream to /ecs-agent and remove /agent/wsclient #3746

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

Realmonia
Copy link
Contributor

Summary

  • Move eventStream to /ecs-agent module for future TCS Handler PR
  • Remove /agent/wsclient as both ACS and TCS client are already using new wsclient

Implementation details

  • Move agent/eventStream directory to ecs-agent/eventStream.
  • Run go mod tidy && go mod vendor in ecs-agent module to download all new dependencies.
  • Update all agent/eventStream imports in agent module with ecs-agent/eventStream.
  • Run go mod tidy && go mod vendor in agent module.

Testing

New tests cover the changes: No

Description for the changelog

Move eventstream to /ecs-agent and remove /agent/wsclient

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Realmonia Realmonia marked this pull request as ready for review June 10, 2023 01:41
@Realmonia Realmonia requested a review from a team as a code owner June 10, 2023 01:41
@Realmonia Realmonia merged commit 8129a5e into aws:dev Jun 12, 2023
@Realmonia Realmonia deleted the tcsHandlerPreChanges branch June 12, 2023 22:05
@prateekchaudhry prateekchaudhry mentioned this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants