Fix Windows CI fail fast #3694
Merged
Fix Windows CI fail fast #3694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singholt
approved these changes
May 12, 2023
chienhanlin
approved these changes
May 12, 2023
arun-annamalai
approved these changes
May 12, 2023
Realmonia
pushed a commit
to Realmonia/amazon-ecs-agent
that referenced
this pull request
May 16, 2023
RichaGangwar
pushed a commit
to RichaGangwar/amazon-ecs-agent
that referenced
this pull request
May 18, 2023
Realmonia
pushed a commit
to Realmonia/amazon-ecs-agent
that referenced
this pull request
May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the Windows CI Unit Test Github workflow does not fail on test failures in
agentmodule. This bug was introduced when tests forecs-agentmodule were added to the workflow in #3651. The root cause is that the test script for Windows does not fail fast if an intermediate step fails with a non-zero code. It only cares about the exit code of the last step.For
windows-latestrunners,pwshis the default shell used for Github workflows. Github documentation forpwshsays -However, the Windows unit tests workflow is not failing fast even when
$ErrorActionPreference = 'stop'is explicitly specified in the script.This PR solves this issue by creating a new workflow step for running
ecs-agenttests against Windows.Testing
Tested by making a unit test fail.
New tests cover the changes: no
Description for the changelog
Fix Windows CI unit tests workflow
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.