Add ecs-agent/ ACS model + cleanup gogenerate make #3643
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Create
ecs-agent/
directory, and add ACS model and gogenerate to that directory.Update/clean up existing gogenerate make targets in
Makefile
.Prior to this change:
make gogenerate
does not actually rungo generate
at allmake gogenerate-init
runsgo generate
for bothagent/
andecs-init/
directoriesImplementation details
ecs-agent/
agent/acs/model
andagent/gogenerate
toecs-agent/acs/model
andecs-agent/gogenerate
ecs-agent
directory and rungo mod init
andgo mod tidy
ecs-agent/go.mod
to match those inagent/go.mod
go mod tidy
andgo mod vendor
agent/acs/model/api/api-2.json
andecs-agent/acs/model/api/api-2.json
with the newly generated filemake get-deps
andmake gogenerate
(dependent on below implementation detail). This replacesagent/acs/model/ecsacs/api.go
andecs-agent/acs/model/ecsacs/api.go
with newly generated filesmake gogenerate-init
target to rungo generate
only forecs-init/
directorymake gogenerate
target to actually rungo generate
, and run it foragent/
andecs-agent/
directoriesTesting
Unit, integration, and functional tests.
Manually test modified make targets locally with
make
command.Description for the changelog
Add ecs-agent/ ACS model + cleanup gogenerate make
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.