Use debug instead of error log for skipped events for internal task/container #3559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For internal tasks (e.g. service connect relay) or internal containers (e.g. pause containers), we do not wish to publish any state change events for them. Currently we log an error message when we encounter such task/container while constructing the events. But that could be noisy and misleading since this is not a real error but rather designed behavior. This PR updates all such error messages to be debug messages.
Implementation details
Created new error type
ErrShouldNotSendEvent
. This error will be returned for internal task/containers when constructing a state change event. Caller will discern this error, and log a debug instead of error message in that case.Testing
make test
New tests cover the changes: no
Description for the changelog
Use debug instead of error log for skipped events for internal task/container
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.