Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check domain join based on the gMSA support env #3489

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

saikiranakula-amzn
Copy link
Contributor

@saikiranakula-amzn saikiranakula-amzn commented Nov 23, 2022

Summary

Fix to validate the domain join only if gMSA support is enabled

fixes error log messages on non-gMSA instances (ie, most instances) like this:

level=error time=2022-XX-XXT03:12:09Z msg=""CREDENTIALS_FETCHER_HOST_DIR not found, err: stat /var/credentials-fetcher/socket/credentials_fetcher.sock: no such file or directory"" module=parse_linux.go"
level=error time=2022-XX-XXT03:12:09Z msg=""CREDENTIALS_FETCHER_HOST_DIR not found, err: stat /var/credentials-fetcher/socket/credentials_fetcher.sock: no such file or directory"" module=parse_linux.go"

Implementation details

Testing

New tests cover the changes:

Description for the changelog

bugfix: don't log errors on instances not using GMSA

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sparrc sparrc merged commit c6a2d92 into aws:dev Dec 5, 2022
@YashdalfTheGray YashdalfTheGray mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants