Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go mod update to fix the make gogenerate failure #3430

Closed
wants to merge 1 commit into from

Conversation

Realmonia
Copy link
Contributor

@Realmonia Realmonia commented Oct 12, 2022

Summary

The hard coded golang.org/x/sys version in replace section is outdated for latest go version. When run make gogenerate we see a lot of errors like this:

# golang.org/x/sys/unix
/Users/hanhm/go/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:28:3: //go:linkname must refer to declared function or variable

The issue is a common error reported here - golang/go#51706. The idea I get from that issue is to pull in a newer golang.org/x/sys package.

Remove the line and run go mod download golang.org/x/sys under /agent directory.

After this package is updated, the above error goes away.

Implementation details

Testing

New tests cover the changes: No. N/A.

Description for the changelog

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Realmonia Realmonia marked this pull request as ready for review October 12, 2022 22:53
@Realmonia Realmonia requested a review from a team as a code owner October 12, 2022 22:53
@Realmonia Realmonia closed this Dec 15, 2022
@Realmonia Realmonia deleted the goModUpdate branch April 12, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants