Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #3277 we introduced a few dependency bumps. However some of the upgrades have introduced build failures of debian packages likely due to Go version compatibility(see #3277 code build workflow to get more details - note that the error is shown in the build log although the final workflow status shows as succeeded).
In this PR, we first revert the change in #3277, and re-do the dependency bumps but keep them to minimal.
Implementation details
git revert f4ca59d
1.1.2
make test-init
To fix the error, removed
replace golang.org/x/sys => golang.org/x/sys v0.0.0-20170529185110-b90f89a1e7a9
in ecs-init go.modTo fix the error, upgraded
docker/docker
to the version that had the fixmake test-init
now passesgeneric-rpm-integrated
Note that:
github.com/opencontainers/image-spec
to use1.0.2
- we are using1.0.3
alreadygithub.com/docker/docker
to use 1.6.1, released in year 2015 - we are using a newer version released in 2021Testing
All code build projects are passing (checked individual build logs to make sure there's no error)
New tests cover the changes: no
Description for the changelog
Dependabot ecs-init fixes
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.