-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GO_VERSION to 1.18.3 #3301
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh09
changed the title
Update Go version in GO_VERSION file to 1.18.3
WIP: Update Go version in GO_VERSION file to 1.18.3
Jul 20, 2022
amogh09
force-pushed
the
go_version_update
branch
from
July 21, 2022 23:25
d03c96b
to
dc253b1
Compare
amogh09
force-pushed
the
go_version_update
branch
from
July 21, 2022 23:44
d75f645
to
ee671ba
Compare
amogh09
force-pushed
the
go_version_update
branch
from
July 22, 2022 00:56
25871e2
to
096ad2d
Compare
amogh09
changed the title
WIP: Update Go version in GO_VERSION file to 1.18.3
Update GO_VERSION to 1.18.3
Jul 22, 2022
YashdalfTheGray
approved these changes
Jul 22, 2022
fierlion
approved these changes
Jul 22, 2022
@@ -68,14 +68,10 @@ type IAMRoleCredentials struct { | |||
type TaskIAMRoleCredentials struct { | |||
ARN string | |||
IAMRoleCredentials IAMRoleCredentials | |||
lock sync.RWMutex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: This lock is likely redundant. There's a taskCredentialsLock which is managing the writes and reads and the usage for this lock is only on reads but is covered by the other outer lock. Approving
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GO_VERSION
file to1.18.3
.staticcheck
as the current version is not compatible with Go 1.18.go get
to install executables withgo install
asgo get
can no longer be used to install executables.type TaskIAMRoleCredentials
which is causing static analysis failures because the lock is being passed around by value.Testing
Automated tests only.
New tests cover the changes: No new tests
Description for the changelog
Update Go version for make builds to 1.18.3.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.