Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GO_VERSION to 1.18.3 #3301

Merged
merged 13 commits into from
Jul 23, 2022
Merged

Update GO_VERSION to 1.18.3 #3301

merged 13 commits into from
Jul 23, 2022

Conversation

amogh09
Copy link
Contributor

@amogh09 amogh09 commented Jul 13, 2022

Summary

  1. Update Go version in GO_VERSION file to 1.18.3.
  2. Upgrade the version of staticcheck as the current version is not compatible with Go 1.18.
  3. Replace usages of go get to install executables with go install as go get can no longer be used to install executables.
  4. Remove a redundant lock field from type TaskIAMRoleCredentials which is causing static analysis failures because the lock is being passed around by value.
  5. Temporarily disable cross-platform builds for Darwin (MacOS) platform in Github CI pipeline as the set of agent code, dependency versions, and Go version (1.18) in this PR does not build for Darwin. We tried fixing the build for Darwin by upgrading the problematic dependencies but that causes agent code to fail compilation. We will tackle this issue separately.

Testing

Automated tests only.

New tests cover the changes: No new tests

Description for the changelog

Update Go version for make builds to 1.18.3.

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@amogh09 amogh09 changed the title Update Go version in GO_VERSION file to 1.18.3 WIP: Update Go version in GO_VERSION file to 1.18.3 Jul 20, 2022
@amogh09 amogh09 changed the title WIP: Update Go version in GO_VERSION file to 1.18.3 Update GO_VERSION to 1.18.3 Jul 22, 2022
@@ -68,14 +68,10 @@ type IAMRoleCredentials struct {
type TaskIAMRoleCredentials struct {
ARN string
IAMRoleCredentials IAMRoleCredentials
lock sync.RWMutex
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: This lock is likely redundant. There's a taskCredentialsLock which is managing the writes and reads and the usage for this lock is only on reads but is covered by the other outer lock. Approving

@amogh09 amogh09 merged commit fe0fbfc into aws:dev Jul 23, 2022
@amogh09 amogh09 deleted the go_version_update branch July 23, 2022 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants