-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop container when dependencies are non-resolvable #3218
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelcar
force-pushed
the
fix/container_ordering_stuck
branch
from
May 19, 2022 22:18
de4672d
to
1836472
Compare
angelcar
changed the title
[WIP]Stop container when dependencies are non-resolvable
Stop container when dependencies are non-resolvable
May 19, 2022
singholt
approved these changes
May 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
fierlion
approved these changes
May 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Thanks for the well reasoned PR with clear tests which act as a walkthrough of the changes.)
rsheik29
pushed a commit
to rsheik29/amazon-ecs-agent
that referenced
this pull request
Jul 11, 2022
Stop container when dependencies are non-resolvable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #2579 where a task can be stuck in
PENDING
for ever when container dependencies cannot be fulfilled.Implementation details
Adding the concept of terminal dependency error to detect cases where container dependencies can never succeed. When a terminal dependency error is detected, we simply forcefully stop the container with the "bad" dependencies.
This new behavior triggers a chain reaction that eventually stops the task if an essential container has terminal dependency errors. If essential containers don't have terminal dependency errors, then the task is allowed to start.
Containers that are forcefully stopped are marked with exitCode
143
. This is the code docker assigns when a container receivesSIGTERM
. Although we technically don't sendSIGTERM
to containers stopped due to terminal dependency errors, this exit code is the closest to reality. However, customers will be able to see a text description of the exact error when this edge case is hit.For example (from AWS console):
Testing
New tests cover the changes: yes
Description for the changelog
Bug - Fix an issue where a task can be stuck in
PENDING
for ever when container dependencies can never be fulfilled.Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.