Improve log readability #3134
Merged
Improve log readability #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelcar
force-pushed
the
log-improvement-round-2
branch
12 times, most recently
from
c5a8c6d
to
3a94531
Compare
angelcar
force-pushed
the
log-improvement-round-2
branch
from
3a94531
to
fe3024b
Compare
singholt
reviewed
Feb 23, 2022
angelcar
force-pushed
the
log-improvement-round-2
branch
from
fe3024b
to
dcd4f7f
Compare
angelcar
force-pushed
the
log-improvement-round-2
branch
from
dcd4f7f
to
f8bb829
Compare
sparrc
approved these changes
Feb 23, 2022
ubhattacharjya
approved these changes
Feb 23, 2022
YashdalfTheGray
approved these changes
Feb 24, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to improve the readability of ECS agent logs. The code changes don't include any major changes in logic, only changes to logging.
Implementation details
Expanded the use of structured logger to improve most relevant logs. In order to decrease verbosity, now we log ony task id instead of the full task arn, which should be sufficient.
Testing
New tests cover the changes: yes
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.