EC2 task networking for Windows: Build vpc-eni CNI plugin for Windows #2893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 5, 2021 12:05
rawahars
force-pushed
the
feature/ec2-awsvpc-windows
branch
from
674faaa
to
a064e92
Compare
rawahars
force-pushed
the
feature/ec2-awsvpc-windows
branch
from
a064e92
to
4aebb8c
Compare
vsiddharth
reviewed
Jun 9, 2021
| @@ -20,4 +20,4 @@ jobs: | |||
| $Env:GOPATH = "$Env:GITHUB_WORKSPACE" | |||
| cd "$Env:GITHUB_WORKSPACE" | |||
| cd "src/github.com/aws/amazon-ecs-agent" | |||
| go test -v -race -tags unit -timeout 40s ./agent/... | |||
| go test -race -tags unit -timeout 40s ./agent/... | |||
There was a problem hiding this comment.
Why did we remove the -v ?
There was a problem hiding this comment.
By removing this flag, we are able to remove the excess noise from the UTs during PR. We can very easily pin point the UT which failed and the corresponding error. For example - https://github.com/aws/amazon-ecs-agent/runs/2786834601?check_suite_focus=true
Also, this ensures that the behavior is same for Linux and Windows UT during PR build.
This change was implemented after discussion with @fenxiong
rawahars
force-pushed
the
feature/ec2-awsvpc-windows
branch
from
4aebb8c
to
5b4a525
Compare
vsiddharth
approved these changes
Jun 10, 2021
| @@ -20,4 +20,4 @@ jobs: | |||
| $Env:GOPATH = "$Env:GITHUB_WORKSPACE" | |||
| cd "$Env:GITHUB_WORKSPACE" | |||
| cd "src/github.com/aws/amazon-ecs-agent" | |||
| go test -v -race -tags unit -timeout 40s ./agent/... | |||
| go test -race -tags unit -timeout 40s ./agent/... | |||
fenxiong
approved these changes
Jun 10, 2021
angelcar
approved these changes
Jun 10, 2021
rawahars
added a commit
to rawahars/amazon-ecs-agent
that referenced
this pull request
Jun 23, 2021
…aws#2893) * Added CNI plugin version upgrade code to common file * Build vpc-eni cni plugin for Windows * Updated the git submodule for vpc-cni plugins * Disabled verbose option for Windows unit tests * Updated git submodule vpc-cni-plugins to latest release * Updated values for max retry during network setup
rawahars
added a commit
to rawahars/amazon-ecs-agent
that referenced
this pull request
Jun 24, 2021
…aws#2893) * Added CNI plugin version upgrade code to common file * Build vpc-eni cni plugin for Windows * Updated the git submodule for vpc-cni plugins * Disabled verbose option for Windows unit tests * Updated git submodule vpc-cni-plugins to latest release * Updated values for max retry during network setup
rawahars
added a commit
to rawahars/amazon-ecs-agent
that referenced
this pull request
Jun 29, 2021
…aws#2893) * Added CNI plugin version upgrade code to common file * Build vpc-eni cni plugin for Windows * Updated the git submodule for vpc-cni plugins * Disabled verbose option for Windows unit tests * Updated git submodule vpc-cni-plugins to latest release * Updated values for max retry during network setup
rawahars
added a commit
to rawahars/amazon-ecs-agent
that referenced
this pull request
Jun 29, 2021
…aws#2893) * Added CNI plugin version upgrade code to common file * Build vpc-eni cni plugin for Windows * Updated the git submodule for vpc-cni plugins * Disabled verbose option for Windows unit tests * Updated git submodule vpc-cni-plugins to latest release * Updated values for max retry during network setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The changes introduced in this PR are-
vpc-eniplugin for WindowsImplementation details
The changes were implemented using -
vpc-eniplugins during the agent buildTesting
A custom binary of the agent was tested.
New tests cover the changes:
No new changes have been introduced.
Description for the changelog
Build vpc-eni plugin for ECS Windows task networking
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.