-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECS agent to acknowledge server heartbeat messages #2837
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
reviewed
Mar 26, 2021
sparrc
reviewed
Mar 26, 2021
sparrc
reviewed
Mar 26, 2021
sparrc
reviewed
Mar 26, 2021
sparrc
reviewed
Mar 26, 2021
sparrc
reviewed
Mar 26, 2021
sparrc
reviewed
Mar 26, 2021
sparrc
reviewed
Mar 26, 2021
fenxiong
reviewed
Apr 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm other than cam's comment
sparrc
previously approved these changes
Apr 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm assuming tests pass
sparrc
approved these changes
Apr 22, 2021
fenxiong
approved these changes
Apr 22, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the support for ECS agent to acknowledge server heartbeat messages. This would help both ECS agent and ECS backend server to detect stale socket connections, then take proactive actions to handle it.
Implementation details
ECS server will soon start to actively clean up stale connections if ECS agent is not acknowledging heartbeat messages. Since such change is backward-incompatible, a new
protocolVersion
is introduced for ECS agent to control the behavior from client side when establishing the WebSocket connection.If the version is set as 2, then the ECS agent must acknowledge all server heartbeats. Null protocol version is treated as 1.
Testing
Manually tested the change by building the agent, connect to ECS, then inspect ECS backend logs:
New tests cover the changes: yes
Description for the changelog
Enhancement - Add support for ECS agent to acknowledge server heartbeat messages
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.