omit pause container network metrics #2836
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For awsvpc network mode, we obtain the network metrics of the task's network interface and divide that equally among other containers in the task excluding the pause container
amazon-ecs-agent/agent/stats/engine.go
Line 273 in 2874131
But it was observed that pause container was still included in the final network metrics calculation leading to incorrect total task's network stats.
This PR fixes it.
Implementation details
do not add network stats to the container if its the pause container
Testing
manual testing:
before changes:
after changes:
New tests cover the changes: yes
Description for the changelog
Bug - Fix task's network stats by omitting pause container in the network metrics calculation.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.