Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass agent context to subroutines #2463

Merged
merged 1 commit into from
May 29, 2020
Merged

Pass agent context to subroutines #2463

merged 1 commit into from
May 29, 2020

Conversation

sparrc
Copy link
Contributor

@sparrc sparrc commented May 28, 2020

Summary

Breaking out #2457 into smaller PRs.

This PR does not explicitly cancel the agent's context, but it passes it to more goroutines and fixes some of the waiting and concurrency logic. The routines that it passes to are:

  1. spot instance draining poller
  2. introspection http endpoint
  3. task metadata http endpoint
  4. engine event handler
  5. tcs handler (already was passing but this change makes it wait and exit correctly when context is cancelled)

Description for the changelog

Fix agent top-level context

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sparrc sparrc requested a review from a team May 28, 2020 16:57
@sparrc sparrc changed the title Pass agent context to more routines Pass agent context to subroutines May 29, 2020
@sparrc sparrc merged commit dc85d71 into aws:dev May 29, 2020
@sparrc sparrc deleted the context-cleanup-2 branch May 29, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants