integ tests: port forwarding #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
force-pushed
the
test-port-forward-wait-stopped
branch
from
458119e
to
a75477b
Compare
always verify that the task is stopped at the end of every test, in case unrelated state change events are received that may trigger a test to exit before it has been cleaned up. also get a new port for each test to avoid potential collisions.
sparrc
force-pushed
the
test-port-forward-wait-stopped
branch
from
a75477b
to
1cb8180
Compare
fenxiong
approved these changes
May 15, 2020
mssrivas
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
always verify that the task is stopped at the end of every test, in case
unrelated state change events are received that may trigger a test to
exit before it has been cleaned up.
also get a new port for each test to avoid potential collisions.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.