Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default docker metric gathering behavior #2452

Merged
merged 3 commits into from
May 18, 2020
Merged

Change default docker metric gathering behavior #2452

merged 3 commits into from
May 18, 2020

Commits on May 15, 2020

  1. Change default docker metric gathering behavior 

    1. Change default docker metric gathering behavior from streaming
metrics to polling.
2. Change the default polling interval to half of the TACS publishing
interval (currently 20s), so that every publish interval we have two
docker metrics.
3. Change the minimum polling interval to 5s to prevent customers from
configuring polling to be just as resource-intensive as streaming
metrics.

These changes are being made because we have found that docker streaming
stats consumes considerable resources from the agent, dockerd daemon, and
containerd daemon.
    @sparrc
    sparrc committed May 15, 2020
    Configuration menu
    Copy the full SHA
    7a714a4 View commit details
    Browse the repository at this point in the history

  2. Task stats endpoint needs to be populated immediately 

    to avoid changing behavior from streaming stats, we need to populate the
stats endpoint immediately when the stats engine starts. So instead of
jittering the first stats gather we need to just do it immediately.
    @sparrc
    sparrc committed May 15, 2020
    Configuration menu
    Copy the full SHA
    c4871aa View commit details
    Browse the repository at this point in the history

  3. Pinning windows images (ltsc201*) to known working version 

    5/12 release broke our tests
    @sparrc
    sparrc committed May 15, 2020
    Configuration menu
    Copy the full SHA
    28ba4aa View commit details
    Browse the repository at this point in the history