Dont ignore json marshal errors #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
force-pushed
the
json-marshal-errors
branch
from
7cd1d2a
to
05d8ca0
Compare
sparrc
changed the title
cyastella
approved these changes
Apr 23, 2020
mythri-garaga
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are places in our codebase where we are ignoring errors from json.Marshal. The vast majority of these cases are basically impossible to return an error, but it's not a good pattern to have in our code and it appears to have been copy and pasted into a few places where we could potentially have errors.
This could also protect us from future code changes that might break json.Marshal.
Implementation details
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.