-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CGroups CPU period configurable #1941
Conversation
cc55aaa
to
593d2d1
Compare
f9fc74d
to
a2ce401
Compare
@adnxn I applied the suggested changes here. |
@adnxn looks like some tests are failing, can I get more details to see if they are related to this change. I remembered last time they all passed. |
ill have to dig into this and try to get you some more information. in the meantime - have you looked at running the make targets for the integ and functional tests? |
@boynux: do you mind rebasing your changes on the latest changes from specifically,
|
a2ce401
to
d10da19
Compare
@adnxn just rebased the latest dev and pushed the update. Let's see. |
@adnxn is there anything I can do for this change? |
@adnxn sorry to bother you again, is this still in your radar? And is there anything I can do to help getting this rolled out? |
no worries, yea it fell off my radar again. we'll have a second person go over the code as well and hopefully get this wrapped up soon. thanks for checking in again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, some minor comments
Signed-off-by: Mohamad Arab <[email protected]>
d10da19
to
7d0acd4
Compare
@fenxiong done as suggested |
@boynux - just to update you, im trying to get these changes tested through our test suites and merged. in the meantime - since this doesnt have any functional tests. would you be able to test and report the failure modes of full task runs at the boundaries of the configurable period? |
update: my bad, that commit is for functional tests. let me dig into whats going on with the integ one |
integ test had failed due to flakey test (TestShutdownOrder): #1931. Test was rerun and all passed now. |
Thanks for approving this change @adnxn |
🎉 |
Signed-off-by: Mohamad Arab [email protected]
Summary
Fixes #1627
Reopen: #1632
Make CFS CPU Period configurable
CFS keeps throttling tasks very excessively if the default period 100ms is specified, to reduce the impact we should be able to set lower CPU period when defining cgroup quotas.
Implementation details
New environment parameter added to adjust CFS period.
Testing
See here: https://gist.github.com/bobrik/2030ff040fad360327a5fab7a09c4ff1
New tests cover the changes: yes
Description for the changelog
Configure CFS scheduler evaluation period from 8ms to 100ms
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.