Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add nonECS image removal #1769

Merged
merged 1 commit into from
Dec 31, 2018
Merged

docs: add nonECS image removal #1769

merged 1 commit into from
Dec 31, 2018

Conversation

adnxn
Copy link
Contributor

@adnxn adnxn commented Dec 31, 2018

Summary

README and CHANGELOG updates for #1752

Implementation details

Testing

  • Builds on Linux (make release)
  • Builds on Windows (go build -out amazon-ecs-agent.exe ./agent)
  • Unit tests on Linux (make test) pass
  • Unit tests on Windows (go test -timeout=25s ./agent/...) pass
  • Integration tests on Linux (make run-integ-tests) pass
  • Integration tests on Windows (.\scripts\run-integ-tests.ps1) pass
  • Functional tests on Linux (make run-functional-tests) pass
  • Functional tests on Windows (.\scripts\run-functional-tests.ps1) pass

New tests cover the changes:

Description for the changelog

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@adnxn adnxn requested review from yhlee-aws and a team December 31, 2018 19:24
@adnxn
Copy link
Contributor Author

adnxn commented Dec 31, 2018

for the following tests:

ecs/linux/unit_test
ecs/linux/unit_test_in_docker

the two unit test target failures are due to panic: test timed out after 25s which are being fixed separately. this is an intermittent failure that shows up in octokitten but not travis. we're in the process of removing the unit test runs from octokitten altogether and executing unit tests through travis only.

ecs/windows/functional_test
the functional test failure is same issue being tracked here #1763.

merging this PR to dev since it contains only documentation changes.

@adnxn adnxn merged commit 0ef9430 into aws:dev Dec 31, 2018
@yumex93 yumex93 added this to the 1.24.0 milestone Jan 2, 2019
@adnxn adnxn deleted the nonecs-images-readme branch February 19, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants