Fixing a few more functional tests #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haikuoliu
approved these changes
Dec 28, 2018
fenxiong
force-pushed
the
v1.24.0-fix
branch
from
3fc204e
to
356da56
Compare
|
Failing windows functional test TestOOMContainer tracked here: #1763 |
yhlee-aws
approved these changes
Dec 31, 2018
ubhattacharjya
approved these changes
Dec 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing a few more functional tests. They were added after 1.23.0 release so i wasn't fixing them in #1751.
Implementation details
TestV3TaskEndpointTags TestTaskMetadataValidator
These two tests are flakey because of the same reason for TestContainerInstanceTags that was fixed in #1751. We cannot enable long arn at the start of test and disable it at the end, because we'd end up with race condition when multiple tests run at the same time.
TestTelemetryWithStatsPolling
This test needs a minimum memory requirement, same as TestTelemetry. i didn't notice this in #1755.
Testing
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passNew tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.