gpu: better logging for debugging #1762
Conversation
agent/gpu/nvidia_gpu_manager_unix.go
Outdated
| @@ -78,6 +79,7 @@ func (n *NvidiaGPUManager) Initialize() error { | |||
| n.SetGPUIDs(gpuIDs) | |||
| n.SetDevices() | |||
| } | |||
| seelog.Info("Config for GPU support is enabled, but GPU information is not found; continuing without it") | |||
There was a problem hiding this comment.
wondering if this should be handled as a failure, for example when customer is expecting to use GPU, shouldn't the customer be notified of the misconfiguration in a more explicit way?
There was a problem hiding this comment.
This config is not recommended for customers to add. This is a GPU instance level config, but we also let customers override it to true/false. If for some reason, a customer sets it to true on non GPU instance, there is value is not stopping agent and continuing to register as a normal instance. I can change the log level to error.
|
flakey windows functional test failure:
|
|
merging PR since failures are not related to the changes |
Summary
Implementation details
Testing
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passNew tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.