Merge ecs-secrets-phase2 branch to dev #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharanyad
reviewed
Dec 3, 2018
| "Version": 17 |
There was a problem hiding this comment.
This is the test case for secrets integrating with ssm(phase 1).
sharanyad
approved these changes
Dec 3, 2018
haikuoliu
approved these changes
Dec 3, 2018
yumex93
force-pushed
the
merge_secrets_phase2
branch
from
404572d
to
e7f4e08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Finished manual testing for secrets phase2, merge ecs-secrets-phase2 branch to dev branch and manually fix conflicts
Implementation details
git merge ecs-secrets-phase2 on dev branch
Testing
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passLicensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.