-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding private registry auth as task resource #1427
Commits on Jun 7, 2018
-
taskresource: add terminalReason msg string
This change adds a terminalReason message to the task struct. The intended use is for the field in the task to be set when the agent explicitly transitions a task to stopped
Configuration menu - View commit details
-
Copy full SHA for 719a1a6 - Browse repository at this point
Copy the full SHA 719a1a6View commit details
Commits on Jun 19, 2018
-
WIP COMMENT: 1. pra resource still needs to implement the marshalling logic + add some concept of durable/not durable resource type for resources that have to be recreated on agent restart. 2. the asm package, needs some refactoring. needs to add some kind of create client factor (for testing) since we're building regional clients for these calls 3. the STSC "reason" field changes have to be consumed by this feature since we're using that to communicate async pra failiures
Configuration menu - View commit details
-
Copy full SHA for 579de94 - Browse repository at this point
Copy the full SHA 579de94View commit details
Commits on Jun 20, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 23d4590 - Browse repository at this point
Copy the full SHA 23d4590View commit details
Commits on Jun 21, 2018
-
asm: add client creator interface
Added a new factory interface in asm package, which creates ASM clients based on the region in ASMAuthConfig. Wired this into the ResourceFields struct in the taskresource package as well.
Configuration menu - View commit details
-
Copy full SHA for 82a6f1d - Browse repository at this point
Copy the full SHA 82a6f1dView commit details -
container/task status: refactor into sub-packages
Move ContainerStatus and TaskStatus into container/status and task/status respectively. This is required for TaskStatus to be used by the TaskResource struct, to avoid circular dependecies.
Configuration menu - View commit details
-
Copy full SHA for e797b90 - Browse repository at this point
Copy the full SHA e797b90View commit details
Commits on Jun 22, 2018
-
asmauth resource: recovery on agent restart
Implemented the Initialize() method for ASM Auth resource, which helps with retrieving registry creds on agent restart. Also, added a factory for creating new ASM SDK clients.
Configuration menu - View commit details
-
Copy full SHA for 79cf221 - Browse repository at this point
Copy the full SHA 79cf221View commit details
Commits on Jul 1, 2018
-
This commit add tests for ASMAuthStatus and also engine test for failiure cases in private registry over ASM code path. This also adds the agent capability for private-registry-authentication.secretsmanager Also includes lint edits.
Configuration menu - View commit details
-
Copy full SHA for c5514eb - Browse repository at this point
Copy the full SHA c5514ebView commit details
Commits on Jul 2, 2018
-
asmauth resource: propagate resource terminal reason to task
This commit branches the docker clients auth data handling logic, ecr and asm auth are handled seperatly. Also includes changes to propagate resource creation failiure reason up to task terminal reason field.
Configuration menu - View commit details
-
Copy full SHA for ebe4eda - Browse repository at this point
Copy the full SHA ebe4edaView commit details
Commits on Jul 3, 2018
-
asmauth resource: check cache before service call
This commit adds a code to check the asm resource cache before making a call to asm. Also adds changes to populate STSC reason field when a stopped containers force a task stop.
Configuration menu - View commit details
-
Copy full SHA for f601106 - Browse repository at this point
Copy the full SHA f601106View commit details
Commits on Jul 6, 2018
-
asmauth resource: added unit tests
This commit adds unit tests to code paths that are exercised using the private registry auth over asm feature.
Configuration menu - View commit details
-
Copy full SHA for 3894385 - Browse repository at this point
Copy the full SHA 3894385View commit details
Commits on Jul 9, 2018
-
Configuration menu - View commit details
-
Copy full SHA for b31733a - Browse repository at this point
Copy the full SHA b31733aView commit details
Commits on Jul 10, 2018
-
app: init resourceFields by default
Previously we were gating creation of factories and managers required by task resources behind the task cpu/memory limits flag. Now we gate the usage behind feature specific flags that require these dependencies.
Configuration menu - View commit details
-
Copy full SHA for 4388e84 - Browse repository at this point
Copy the full SHA 4388e84View commit details