Pr 1148 for 1.16.x #1152
Merged
Pr 1148 for 1.16.x #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds back-off retry logic in: * udev watcher: It takes a few milliseconds for the ENI's mac address to show up on the instance once udev watcher detects that a new device has been attached * eni state lookup: If for whatever reason, there's a delay in ACS sending the ENI attachment message to the agent, the agent's state remains unaware of the ENI This should lead to improved task start latencies of awsvpc tasks.
jahkeup
approved these changes
Dec 27, 2017
richardpen
approved these changes
Dec 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a port of the changes from #1148 to the v1.16.x branch. It was generated with:
git cherry-pick origin/dev..origin/pr/1148The merge completely cleanly with no conflicts except the expected CHANGELOG.md conflicts.
Testing
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passNew tests cover the changes:
Description for the changelog
Licensing
This contribution is under the terms of the Apache 2.0 License: