Fix container change not reported when task status is NONE #1076
Conversation
|
I've tested this with my repro case for #1075 and it passes. Task shows |
agent/api/ecsclient/client.go
Outdated
| seelog.Warnf("SubmitTaskStateChange called with an invalid change: %s", change.String()) | ||
| return errors.New("ecs api client: SubmitTaskStateChange called with an invalid change") | ||
| } | ||
|
|
||
| if change.Status != api.TaskRunning && change.Status != api.TaskStopped && len(change.Containers) == 0 { |
There was a problem hiding this comment.
let's also get rid of this block altogether. This determination should be happening in sendableEvent .taskShouldBeSent method: https://github.com/richardpen/amazon-ecs-agent/blob/fix-1075/agent/eventhandler/task_handler_types.go#L67
Summary
Fix #1075
Implementation details
Task status with NONE is dropped in taskShouldBeSent, this commit makes the taskShouldBeSent more clear and stronger to handle both container event and task event.
Testing
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passNew tests cover the changes:
yes
Description for the changelog
Licensing
This contribution is under the terms of the Apache 2.0 License:
yes