1.15.1 #1068
Merged
1.15.1 #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nmeyerhans
commented
Nov 10, 2017
nmeyerhans
commented
- Bug - Fixed a bug where container state information wasn't reported. #1067
- Bug - Fixed a bug where a task can be blocked in creating state. #1048
- Bug - Fixed dynamic HostPort in container metadata. #1052
In task/container overridden, it's copying the task/container struct which has a lock, this could cause deadlock if some other go routine acquired the lock right before copying and released the lock after the copy. This commit moved the overridden part to ACS when unmarshal the task from payload message.
jhaynes
approved these changes
Nov 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.