Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AD-637] Workaround error SQLPrimaryKeys ( return stub/empty) #42

Merged
merged 7 commits into from
Mar 17, 2022

Conversation

birschick-bq
Copy link
Contributor

@birschick-bq birschick-bq commented Mar 8, 2022

Summary

[AD-637] Workaround error SQLPrimaryKeys ( return stub/empty)

Description

Return SQL_NO_DATA in all cases.

Related Issue

https://bitquill.atlassian.net/browse/AD-637

Additional Reviewers

@affonsoBQ
@alexey-temnikov
@andiem-bq
@birschick-bq
@alinaliBQ

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

MacOS Big Sur 11 Build Unit Test Results

    1 files  ±  0    1 suites  ±0   2s ⏱️ -25s
168 tests +32  19 ✔️  - 27  148 💤 +58  0 ±0  1 🔥 +1 
  25 runs   - 21  -7 ✔️ +37    31 💤  - 59  0 ±0  1 🔥 +1 

For more details on these errors, see this check.

Results for commit 2f3fccc. ± Comparison against base commit 1842345.

This pull request skips 27 tests.
ConnectionTestSuite ‑ TestConnectionIncompleteBasicProperties
ConnectionTestSuite ‑ TestConnectionIncompleteSSHTunnelProperties
ConnectionTestSuite ‑ TestConnectionInvalidUser
ConnectionTestSuite ‑ TestConnectionRestoreExternalSSHTunnel
ConnectionTestSuite ‑ TestConnectionRestoreMiscOptionsSet
JavaTestSuite ‑ TestConnectionGetMetaData
JavaTestSuite ‑ TestDatabaseMetaDataGetColumns
JavaTestSuite ‑ TestDatabaseMetaDataGetTables
JavaTestSuite ‑ TestDocumentDbConnectionGetDatabaseMetadata
JavaTestSuite ‑ TestDocumentDbConnectionGetSshTunnelPort
…

♻️ This comment has been updated with latest results.

@birschick-bq birschick-bq changed the title [AD-637] [ODBC] Workaround error SQLPrimaryKeys ( return stub/empty) [AD-637] Workaround error SQLPrimaryKeys ( return stub/empty) Mar 8, 2022
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

Windows 2022 (x32) Build Unit Test Results

    1 files  ±  0    1 suites  ±0   32s ⏱️ -1s
168 tests +32  47 ✔️ +  1  121 💤 +31  0 ±0 
  47 runs  +  1  -74 ✔️  - 30  121 💤 +31  0 ±0 

Results for commit 2f3fccc. ± Comparison against base commit 1842345.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

Windows 2022 (x64) Build Unit Test Results

    1 files  ±  0    1 suites  ±0   45s ⏱️ -37s
168 tests +32  47 ✔️ +  1  121 💤 +31  0 ±0 
  47 runs  +  1  -74 ✔️  - 30  121 💤 +31  0 ±0 

Results for commit 2f3fccc. ± Comparison against base commit 1842345.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@alinaliBQ alinaliBQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@birschick-bq birschick-bq merged commit e6429aa into develop Mar 17, 2022
@birschick-bq birschick-bq deleted the birschick-bq/ad-637/stub_primary_keys branch March 17, 2022 16:58
birschick-bq pushed a commit that referenced this pull request Jun 15, 2022
### Summary

<!--- General summary / title -->
Add log message to statement.cpp.
### Description

<!--- Details of what you changed -->
rowArraySize should not hold values other than 1, therefore putting a log to indicate it better
### Related Issue

<!--- Link to issue where this is tracked -->
https://bitquill.atlassian.net/browse/AD-801

* [AD-801] add logs

* rowArraySize should not hold values other than 1, therefore putting a log to indicate it better

* [AD-801] reformat

* [AD-801] address code review comments
affonsov pushed a commit that referenced this pull request Nov 16, 2022
* enable tests for SQLGet/SetDescField

* enable SQLBindCol tests

* return 07009 when column number exceeds max number of column in result set for SQLBindCol

* return HY090 when buffer length is less than 0

* add back APP_ROW_GET test

* rebranding

* fix TestSQLRowCount fixture

* remove unused var
affonsov pushed a commit that referenced this pull request Nov 16, 2022
### Summary

[AD-637] Workaround error SQLPrimaryKeys ( return stub/empty)

### Description

Return SQL_NO_DATA in all cases.

### Related Issue

https://bitquill.atlassian.net/browse/AD-637

* [AD-637] [ODBC] Workaround error SQLPrimaryKeys ( return stub/empty)

* [AD-637] * Attempt change to make MacOS test not crash.

* [AD-637] * Attempt change to make MacOS test not crash.

* [AD-637] * Attempt change to make MacOS test not crash.

* [AD-637] * Revert test back to baseline.

* [AD-637] * Attempt change to make MacOS test not crash.
affonsov pushed a commit that referenced this pull request Nov 17, 2022
* enable tests for SQLGet/SetDescField

* enable SQLBindCol tests

* return 07009 when column number exceeds max number of column in result set for SQLBindCol

* return HY090 when buffer length is less than 0

* add back APP_ROW_GET test

* rebranding

* fix TestSQLRowCount fixture

* remove unused var
affonsov pushed a commit that referenced this pull request Nov 17, 2022
### Summary

[AD-637] Workaround error SQLPrimaryKeys ( return stub/empty)

### Description

Return SQL_NO_DATA in all cases.

### Related Issue

https://bitquill.atlassian.net/browse/AD-637

* [AD-637] [ODBC] Workaround error SQLPrimaryKeys ( return stub/empty)

* [AD-637] * Attempt change to make MacOS test not crash.

* [AD-637] * Attempt change to make MacOS test not crash.

* [AD-637] * Attempt change to make MacOS test not crash.

* [AD-637] * Revert test back to baseline.

* [AD-637] * Attempt change to make MacOS test not crash.
alexey-temnikov pushed a commit that referenced this pull request Jan 14, 2023
* enable tests for SQLGet/SetDescField

* enable SQLBindCol tests

* return 07009 when column number exceeds max number of column in result set for SQLBindCol

* return HY090 when buffer length is less than 0

* add back APP_ROW_GET test

* rebranding

* fix TestSQLRowCount fixture

* remove unused var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants