-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AD-637] Workaround error SQLPrimaryKeys ( return stub/empty) #42
Conversation
MacOS Big Sur 11 Build Unit Test Results 1 files ± 0 1 suites ±0 2s ⏱️ -25s For more details on these errors, see this check. Results for commit 2f3fccc. ± Comparison against base commit 1842345. This pull request skips 27 tests.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
### Summary <!--- General summary / title --> Add log message to statement.cpp. ### Description <!--- Details of what you changed --> rowArraySize should not hold values other than 1, therefore putting a log to indicate it better ### Related Issue <!--- Link to issue where this is tracked --> https://bitquill.atlassian.net/browse/AD-801 * [AD-801] add logs * rowArraySize should not hold values other than 1, therefore putting a log to indicate it better * [AD-801] reformat * [AD-801] address code review comments
* enable tests for SQLGet/SetDescField * enable SQLBindCol tests * return 07009 when column number exceeds max number of column in result set for SQLBindCol * return HY090 when buffer length is less than 0 * add back APP_ROW_GET test * rebranding * fix TestSQLRowCount fixture * remove unused var
### Summary [AD-637] Workaround error SQLPrimaryKeys ( return stub/empty) ### Description Return SQL_NO_DATA in all cases. ### Related Issue https://bitquill.atlassian.net/browse/AD-637 * [AD-637] [ODBC] Workaround error SQLPrimaryKeys ( return stub/empty) * [AD-637] * Attempt change to make MacOS test not crash. * [AD-637] * Attempt change to make MacOS test not crash. * [AD-637] * Attempt change to make MacOS test not crash. * [AD-637] * Revert test back to baseline. * [AD-637] * Attempt change to make MacOS test not crash.
* enable tests for SQLGet/SetDescField * enable SQLBindCol tests * return 07009 when column number exceeds max number of column in result set for SQLBindCol * return HY090 when buffer length is less than 0 * add back APP_ROW_GET test * rebranding * fix TestSQLRowCount fixture * remove unused var
### Summary [AD-637] Workaround error SQLPrimaryKeys ( return stub/empty) ### Description Return SQL_NO_DATA in all cases. ### Related Issue https://bitquill.atlassian.net/browse/AD-637 * [AD-637] [ODBC] Workaround error SQLPrimaryKeys ( return stub/empty) * [AD-637] * Attempt change to make MacOS test not crash. * [AD-637] * Attempt change to make MacOS test not crash. * [AD-637] * Attempt change to make MacOS test not crash. * [AD-637] * Revert test back to baseline. * [AD-637] * Attempt change to make MacOS test not crash.
* enable tests for SQLGet/SetDescField * enable SQLBindCol tests * return 07009 when column number exceeds max number of column in result set for SQLBindCol * return HY090 when buffer length is less than 0 * add back APP_ROW_GET test * rebranding * fix TestSQLRowCount fixture * remove unused var
Summary
[AD-637] Workaround error SQLPrimaryKeys ( return stub/empty)
Description
Return SQL_NO_DATA in all cases.
Related Issue
https://bitquill.atlassian.net/browse/AD-637
Additional Reviewers
@affonsoBQ
@alexey-temnikov
@andiem-bq
@birschick-bq
@alinaliBQ