Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AD-599] Adapt to use all DSN configuration on mongo cxx driver connection #118

Merged
merged 5 commits into from
Sep 16, 2022
Merged

[AD-599] Adapt to use all DSN configuration on mongo cxx driver connection #118

merged 5 commits into from
Sep 16, 2022

Conversation

affonsov
Copy link
Contributor

Summary

Adapt to use all DSN configuration on mongo cxx driver connection

Description

Adapted mongo options to be applied in the cpp connection string.
Changed to comply with mongo API 4.0 which is case sensitive

Related Issue

https://bitquill.atlassian.net/browse/AD-599
https://bitquill.atlassian.net/browse/AD-598

Additional Reviewers

@affonsoBQ
@alexey-temnikov
@alinaliBQ
@andiem-bq
@birschick-bq
@mitchell-elholm
@RoyZhang2022

@github-actions
Copy link

github-actions bot commented Sep 14, 2022 •
edited
Loading

MacOS Big Sur 11 Debug Build Unit Test Results

    1 files  ±0      1 suites  ±0   39s ⏱️ ±0s
272 tests +2  260 ✔️ +2  12 💤 ±0  0 ❌ ±0 
260 runs  +2  248 ✔️ +2  12 💤 ±0  0 ❌ ±0 

Results for commit 35236ce. ± Comparison against base commit e9bd3e2.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both. 
MetaQueriesTestSuite ‑ TestGetDataWithGetTypeInfo

JniTestSuite ‑ TestDocumentDbDatabaseMetaDataGetTypeInfo
MetaQueriesTestSuite ‑ TestGetTypeInfoAll
MetaQueriesTestSuite ‑ TestGetTypeInfoSingle

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 14, 2022 •
edited
Loading

Windows 2022 (x64) Build Unit Test Results

    1 files  ±0      1 suites  ±0   1m 5s ⏱️ +2s
275 tests +2  263 ✔️ +2  12 💤 ±0  0 ❌ ±0 
263 runs  +2  251 ✔️ +2  12 💤 ±0  0 ❌ ±0 

Results for commit 35236ce. ± Comparison against base commit e9bd3e2.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both. 
MetaQueriesTestSuite ‑ TestGetDataWithGetTypeInfo

JniTestSuite ‑ TestDocumentDbDatabaseMetaDataGetTypeInfo
MetaQueriesTestSuite ‑ TestGetTypeInfoAll
MetaQueriesTestSuite ‑ TestGetTypeInfoSingle

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 14, 2022 •
edited
Loading

Windows 2022 (x32) Build Unit Test Results

    1 files  ±0      1 suites  ±0   1m 11s ⏱️ +10s
275 tests +2  263 ✔️ +2  12 💤 ±0  0 ❌ ±0 
263 runs  +2  251 ✔️ +2  12 💤 ±0  0 ❌ ±0 

Results for commit 35236ce. ± Comparison against base commit e9bd3e2.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both. 
MetaQueriesTestSuite ‑ TestGetDataWithGetTypeInfo

JniTestSuite ‑ TestDocumentDbDatabaseMetaDataGetTypeInfo
MetaQueriesTestSuite ‑ TestGetTypeInfoAll
MetaQueriesTestSuite ‑ TestGetTypeInfoSingle

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 14, 2022 •
edited
Loading

Ubuntu 20.04 Debug Build Unit Test Results

    1 files  ±0      1 suites  ±0   33s ⏱️ +4s
275 tests +2  263 ✔️ +2  12 💤 ±0  0 ❌ ±0 
263 runs  +2  263 ✔️ +2    0 💤 ±0  0 ❌ ±0 

Results for commit 35236ce. ± Comparison against base commit e9bd3e2.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both. 
MetaQueriesTestSuite ‑ TestGetDataWithGetTypeInfo

JniTestSuite ‑ TestDocumentDbDatabaseMetaDataGetTypeInfo
MetaQueriesTestSuite ‑ TestGetTypeInfoAll
MetaQueriesTestSuite ‑ TestGetTypeInfoSingle

♻️ This comment has been updated with latest results.

affonsov
affonsov commented Sep 14, 2022
View reviewed changes
src/odbc/src/connection.cpp Show resolved Hide resolved
src/odbc/src/connection.cpp Show resolved Hide resolved
alinaliBQ
alinaliBQ reviewed Sep 16, 2022
View reviewed changes
Copy link
Contributor

@alinaliBQ alinaliBQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

src/odbc/src/config/configuration.cpp Outdated Show resolved Hide resolved
src/odbc/src/config/configuration.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

MacOS Big Sur 11 Debug Build Code Coverage Result

Code Coverage

Package Line Rate Branch Rate Complexity Health
src.odbc.include.documentdb.odbc 29% 37% 0 ❌
src.odbc.include.documentdb.odbc.app 20% 0% 0 ❌
src.odbc.include.documentdb.odbc.binary 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.cache.query 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.cluster 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.common 13% 11% 0 ❌
src.odbc.include.documentdb.odbc.compute 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.config 86% 50% 0 ✔
src.odbc.include.documentdb.odbc.diagnostic 86% 50% 0 ✔
src.odbc.include.documentdb.odbc.impl 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.impl.binary 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.impl.cache 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.impl.cache.query 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.impl.cache.query.continuous 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.impl.compute 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.impl.interop 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.jni 48% 40% 0 ❌
src.odbc.include.documentdb.odbc.meta 47% 50% 0 ❌
src.odbc.include.documentdb.odbc.query 15% 0% 0 ❌
src.odbc.include.documentdb.odbc.sql 11% 0% 0 ❌
src.odbc.include.documentdb.odbc.streaming 0% 0% 0 ❌
src.odbc.os.linux.include.documentdb.odbc.common 0% 0% 0 ❌
src.odbc.os.linux.src.common 34% 35% 0 ❌
src.odbc.src 49% 28% 0 ❌
src.odbc.src.app 16% 3% 0 ❌
src.odbc.src.binary 0% 0% 0 ❌
src.odbc.src.cluster 2% 0% 0 ❌
src.odbc.src.common 22% 10% 0 ❌
src.odbc.src.config 71% 45% 0 ➖
src.odbc.src.diagnostic 44% 14% 0 ❌
src.odbc.src.impl 1% 0% 0 ❌
src.odbc.src.impl.binary 0% 0% 0 ❌
src.odbc.src.impl.cache 2% 0% 0 ❌
src.odbc.src.impl.cache.query 1% 0% 0 ❌
src.odbc.src.impl.cache.query.continuous 0% 0% 0 ❌
src.odbc.src.impl.cluster 2% 0% 0 ❌
src.odbc.src.impl.compute 0% 0% 0 ❌
src.odbc.src.impl.interop 1% 0% 0 ❌
src.odbc.src.jni 66% 26% 0 ➖
src.odbc.src.jni.os.linux 46% 23% 0 ❌
src.odbc.src.meta 89% 54% 0 ✔
src.odbc.src.query 64% 28% 0 ➖
src.odbc.src.sql 25% 9% 0 ❌
src.odbc.src.streaming 3% 0% 0 ❌
Summary 37% (6069 / 16319) 23% (9553 / 41948) 0 ❌

@github-actions
Copy link

Ubuntu 20.04 Debug Build Unit Test Results Check

Code Coverage

Package Line Rate Branch Rate Complexity Health
src.odbc.include.documentdb.odbc 41% 39% 0 ❌
src.odbc.include.documentdb.odbc.app 45% 0% 0 ❌
src.odbc.include.documentdb.odbc.binary 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.cache.query 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.common 62% 35% 0 ➖
src.odbc.include.documentdb.odbc.compute 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.config 100% 50% 0 ✔
src.odbc.include.documentdb.odbc.diagnostic 82% 50% 0 ✔
src.odbc.include.documentdb.odbc.impl 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.impl.binary 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.impl.cache.query 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.impl.cache.query.continuous 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.impl.compute 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.impl.interop 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.jni 77% 39% 0 ✔
src.odbc.include.documentdb.odbc.meta 71% 50% 0 ➖
src.odbc.include.documentdb.odbc.query 20% 0% 0 ❌
src.odbc.include.documentdb.odbc.sql 50% 11% 0 ➖
src.odbc.include.documentdb.odbc.streaming 0% 0% 0 ❌
src.odbc.os.linux.include.documentdb.odbc.common 0% 0% 0 ❌
src.odbc.os.linux.src.common 34% 42% 0 ❌
src.odbc.src 47% 28% 0 ❌
src.odbc.src.app 25% 13% 0 ❌
src.odbc.src.binary 0% 0% 0 ❌
src.odbc.src.cluster 0% 0% 0 ❌
src.odbc.src.common 28% 18% 0 ❌
src.odbc.src.config 71% 45% 0 ➖
src.odbc.src.diagnostic 33% 12% 0 ❌
src.odbc.src.impl 0% 0% 0 ❌
src.odbc.src.impl.binary 0% 0% 0 ❌
src.odbc.src.impl.cache 0% 0% 0 ❌
src.odbc.src.impl.cache.query 0% 0% 0 ❌
src.odbc.src.impl.cache.query.continuous 0% 0% 0 ❌
src.odbc.src.impl.cluster 0% 0% 0 ❌
src.odbc.src.impl.compute 0% 0% 0 ❌
src.odbc.src.impl.interop 0% 0% 0 ❌
src.odbc.src.jni 63% 27% 0 ➖
src.odbc.src.jni.os.linux 38% 20% 0 ❌
src.odbc.src.meta 88% 54% 0 ✔
src.odbc.src.query 60% 27% 0 ➖
src.odbc.src.sql 18% 8% 0 ❌
src.odbc.src.streaming 0% 0% 0 ❌
Summary 38% (6001 / 15892) 25% (9170 / 37095) 0 ❌

@github-actions
Copy link

Windows 2022 (x32) Debug Build Unit Test Results Check

Code Coverage

Package Line Rate Branch Rate Complexity Health
D:\a\amazon-documentdb-odbc-driver\amazon-documentdb-odbc-driver\build\odbc\bin\Debug\documentdb.odbc.dll 33% 0% 0 ❌
Summary 33% (6997 / 20982) 0% (0 / 0) 0 ❌

alinaliBQ
alinaliBQ reviewed Sep 16, 2022
View reviewed changes
Copy link
Contributor

@alinaliBQ alinaliBQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

andiemontoyeah
andiemontoyeah reviewed Sep 16, 2022
View reviewed changes
Copy link
Contributor

@andiemontoyeah andiemontoyeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@affonsov affonsov merged commit 254bb83 into develop Sep 16, 2022
@affonsov affonsov deleted the affonsov/ad-599/use-all-DSN-configuration-on-mongo-cxx branch September 16, 2022 22:04
affonsov added a commit that referenced this pull request Nov 16, 2022
@affonsov @alinaliBQ
[AD-599] Adapt to use all DSN configuration on mongo cxx driver conne…
73f9a74 
…ction (#118)

* adapted all dsn configuration to be used on mongo cxx driver

* fixed local test connection and unit tests

* [AD-599] Set the allow_invalid_certificates option.

* Apply suggestions from code review

Co-authored-by: Alina (Xi) Li <[email protected]>

* Apply suggestions from code review

Co-authored-by: Bruce Irschick <[email protected]>
Co-authored-by: Alina (Xi) Li <[email protected]>
affonsov added a commit that referenced this pull request Nov 17, 2022
@affonsov @alinaliBQ
[AD-599] Adapt to use all DSN configuration on mongo cxx driver conne…
a431ce3 
…ction (#118)

* adapted all dsn configuration to be used on mongo cxx driver

* fixed local test connection and unit tests

* [AD-599] Set the allow_invalid_certificates option.

* Apply suggestions from code review

Co-authored-by: Alina (Xi) Li <[email protected]>

* Apply suggestions from code review

Co-authored-by: Bruce Irschick <[email protected]>
Co-authored-by: Alina (Xi) Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinaliBQ alinaliBQ alinaliBQ left review comments

@andiemontoyeah andiemontoyeah andiemontoyeah left review comments

@birschick-bq birschick-bq birschick-bq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@affonsov @birschick-bq @andiemontoyeah @alinaliBQ