[AD-909] Enable SQL_ATTR_ROW_ARRAY_SIZE statement attribute greater than 1. #114

birschick-bq · 2022-08-30T19:37:34Z

Summary

[AD-909] Enable SQL_ATTR_ROW_ARRAY_SIZE statement attribute greater than 1.

Description

enable row array size other than 1.
Re-enable tests for handling case greater than 1.
Fix two discovered bugs (SQL state test, expected SQL state value)
Update performance executable to take user and password on command line to support DSN that doesn't include stored user and password.

Related Issue

https://bitquill.atlassian.net/browse/AD-876

Additional Reviewers

@affonsoBQ
@alexey-temnikov
@alinaliBQ
@andiem-bq
@birschick-bq
@mitchell-elholm
@RoyZhang2022

… bugs.

github-actions · 2022-08-30T19:50:17Z

Windows 2022 (x32) Build Unit Test Results

    1 files ±0     1 suites ±0 1m 3s ⏱️ -4s
273 tests +2 261 ✔️ +2 12 💤 ±0 0 ❌ ±0
261 runs +2 249 ✔️ +2 12 💤 ±0 0 ❌ ±0

Results for commit 6a4a69f. ± Comparison against base commit b4482f3.

♻️ This comment has been updated with latest results.

github-actions · 2022-08-30T19:51:58Z

MacOS Big Sur 11 Debug Build Unit Test Results

    1 files ±0     1 suites ±0 37s ⏱️ -19s
270 tests +2 258 ✔️ +2 12 💤 ±0 0 ❌ ±0
258 runs +2 246 ✔️ +2 12 💤 ±0 0 ❌ ±0

Results for commit 6a4a69f. ± Comparison against base commit b4482f3.

♻️ This comment has been updated with latest results.

github-actions · 2022-08-30T19:53:39Z

Windows 2022 (x64) Build Unit Test Results

    1 files ±0     1 suites ±0 1m 7s ⏱️ -3s
273 tests +2 261 ✔️ +2 12 💤 ±0 0 ❌ ±0
261 runs +2 249 ✔️ +2 12 💤 ±0 0 ❌ ±0

Results for commit 6a4a69f. ± Comparison against base commit b4482f3.

♻️ This comment has been updated with latest results.

github-actions · 2022-08-30T20:00:28Z

Ubuntu 20.04 Debug Build Unit Test Results

    1 files ±0     1 suites ±0 27s ⏱️ +4s
273 tests +2 261 ✔️ +2 12 💤 ±0 0 ❌ ±0
261 runs +2 261 ✔️ +2   0 💤 ±0 0 ❌ ±0

Results for commit 6a4a69f. ± Comparison against base commit b4482f3.

♻️ This comment has been updated with latest results.

src/odbc-test/src/api_robustness_test.cpp

src/odbc-test/src/cursor_binding_test.cpp

src/odbc-test/src/odbc_test_suite.cpp

src/odbc/include/documentdb/odbc/documentdb_error.h

src/odbc/src/query/data_query.cpp

src/odbc/src/statement.cpp

src/tests/performance/include/performance_test_runner.h

src/tests/performance/src/performance.cpp

src/tests/performance/src/performance_test_runner.cpp

affonsov

lgtm, just small nit to add a TODO and create a ticket. I will approve after those changes

src/tests/performance/include/performance_test_runner.h

birschick-bq · 2022-09-01T17:32:13Z

lgtm, just small nit to add a TODO and create a ticket. I will approve after those changes

Create a ticket Performance test can be run with a ROW ARRAY SIZE greater than 1. and updated comment.

src/odbc-test/src/api_robustness_test.cpp

src/odbc-test/src/cursor_binding_test.cpp

src/odbc-test/include/odbc_test_suite.h

src/odbc-test/src/cursor_binding_test.cpp

src/odbc-test/src/odbc_test_suite.cpp

src/tests/performance/src/performance.cpp

src/odbc-test/src/api_robustness_test.cpp

Co-authored-by: Alina (Xi) Li <[email protected]>

github-actions · 2022-09-02T20:17:07Z

MacOS Big Sur 11 Debug Build Code Coverage Result

Package	Line Rate	Branch Rate	Health
src.odbc.include.documentdb.odbc	29%	37%	❌
src.odbc.include.documentdb.odbc.app	20%	0%	❌
src.odbc.include.documentdb.odbc.binary	0%	0%	❌
src.odbc.include.documentdb.odbc.cache.query	0%	0%	❌
src.odbc.include.documentdb.odbc.cluster	0%	0%	❌
src.odbc.include.documentdb.odbc.common	13%	11%	❌
src.odbc.include.documentdb.odbc.compute	0%	0%	❌
src.odbc.include.documentdb.odbc.config	86%	50%	✔
src.odbc.include.documentdb.odbc.diagnostic	86%	50%	✔
src.odbc.include.documentdb.odbc.impl	0%	0%	❌
src.odbc.include.documentdb.odbc.impl.binary	0%	0%	❌
src.odbc.include.documentdb.odbc.impl.cache	0%	0%	❌
src.odbc.include.documentdb.odbc.impl.cache.query	0%	0%	❌
src.odbc.include.documentdb.odbc.impl.cache.query.continuous	0%	0%	❌
src.odbc.include.documentdb.odbc.impl.compute	0%	0%	❌
src.odbc.include.documentdb.odbc.impl.interop	0%	0%	❌
src.odbc.include.documentdb.odbc.jni	48%	40%	❌
src.odbc.include.documentdb.odbc.meta	47%	50%	❌
src.odbc.include.documentdb.odbc.query	15%	0%	❌
src.odbc.include.documentdb.odbc.sql	11%	0%	❌
src.odbc.include.documentdb.odbc.streaming	0%	0%	❌
src.odbc.os.linux.include.documentdb.odbc.common	0%	0%	❌
src.odbc.os.linux.src.common	34%	35%	❌
src.odbc.src	49%	28%	❌
src.odbc.src.app	16%	3%	❌
src.odbc.src.binary	0%	0%	❌
src.odbc.src.cluster	2%	0%	❌
src.odbc.src.common	22%	10%	❌
src.odbc.src.config	70%	44%	➖
src.odbc.src.diagnostic	44%	20%	❌
src.odbc.src.impl	1%	0%	❌
src.odbc.src.impl.binary	0%	0%	❌
src.odbc.src.impl.cache	2%	0%	❌
src.odbc.src.impl.cache.query	1%	0%	❌
src.odbc.src.impl.cache.query.continuous	0%	0%	❌
src.odbc.src.impl.cluster	2%	0%	❌
src.odbc.src.impl.compute	0%	0%	❌
src.odbc.src.impl.interop	1%	0%	❌
src.odbc.src.jni	66%	26%	➖
src.odbc.src.jni.os.linux	46%	23%	❌
src.odbc.src.meta	89%	54%	✔
src.odbc.src.query	63%	27%	➖
src.odbc.src.sql	25%	9%	❌
src.odbc.src.streaming	3%	0%	❌
Summary	37% (5978 / 16228)	23% (9436 / 41553)	❌

github-actions · 2022-09-02T20:22:32Z

Ubuntu 20.04 Debug Build Unit Test Results Check

Package	Line Rate	Branch Rate	Health
src.odbc.include.documentdb.odbc	41%	39%	❌
src.odbc.include.documentdb.odbc.app	45%	0%	❌
src.odbc.include.documentdb.odbc.binary	0%	0%	❌
src.odbc.include.documentdb.odbc.cache.query	0%	0%	❌
src.odbc.include.documentdb.odbc.common	62%	35%	➖
src.odbc.include.documentdb.odbc.compute	0%	0%	❌
src.odbc.include.documentdb.odbc.config	100%	50%	✔
src.odbc.include.documentdb.odbc.diagnostic	82%	50%	✔
src.odbc.include.documentdb.odbc.impl	0%	0%	❌
src.odbc.include.documentdb.odbc.impl.binary	0%	0%	❌
src.odbc.include.documentdb.odbc.impl.cache.query	0%	0%	❌
src.odbc.include.documentdb.odbc.impl.cache.query.continuous	0%	0%	❌
src.odbc.include.documentdb.odbc.impl.compute	0%	0%	❌
src.odbc.include.documentdb.odbc.impl.interop	0%	0%	❌
src.odbc.include.documentdb.odbc.jni	77%	39%	✔
src.odbc.include.documentdb.odbc.meta	71%	50%	➖
src.odbc.include.documentdb.odbc.query	20%	0%	❌
src.odbc.include.documentdb.odbc.sql	50%	11%	➖
src.odbc.include.documentdb.odbc.streaming	0%	0%	❌
src.odbc.os.linux.include.documentdb.odbc.common	0%	0%	❌
src.odbc.os.linux.src.common	34%	42%	❌
src.odbc.src	46%	28%	❌
src.odbc.src.app	25%	13%	❌
src.odbc.src.binary	0%	0%	❌
src.odbc.src.cluster	0%	0%	❌
src.odbc.src.common	28%	18%	❌
src.odbc.src.config	70%	45%	➖
src.odbc.src.diagnostic	33%	15%	❌
src.odbc.src.impl	0%	0%	❌
src.odbc.src.impl.binary	0%	0%	❌
src.odbc.src.impl.cache	0%	0%	❌
src.odbc.src.impl.cache.query	0%	0%	❌
src.odbc.src.impl.cache.query.continuous	0%	0%	❌
src.odbc.src.impl.cluster	0%	0%	❌
src.odbc.src.impl.compute	0%	0%	❌
src.odbc.src.impl.interop	0%	0%	❌
src.odbc.src.jni	63%	27%	➖
src.odbc.src.jni.os.linux	38%	20%	❌
src.odbc.src.meta	88%	54%	✔
src.odbc.src.query	59%	27%	➖
src.odbc.src.sql	18%	8%	❌
src.odbc.src.streaming	0%	0%	❌
Summary	37% (5909 / 15812)	25% (9061 / 36754)	❌

github-actions · 2022-09-02T20:26:20Z

Windows 2022 (x32) Debug Build Unit Test Results Check

Package	Line Rate	Branch Rate	Complexity	Health
D:\a\amazon-documentdb-odbc-driver\amazon-documentdb-odbc-driver\build\odbc\bin\Debug\documentdb.odbc.dll	33%	0%	0	❌
Summary	33% (6923 / 20903)	0% (0 / 0)	0	❌

…han 1. (#114) * [AD-909] Implement row_array_size statement attribute. Fix discovered bugs. * [AD-909] Attempt to resolve MacOS test issues. * [AD-909] Attempt to resolve MacOS test issues. * [AD-909] Attempt to resolve MacOS test issues. * [AD-909] Fix compile error. * [AD-909] Clean-up code. * [AD-876] Code review improvement to add ticket for performance tests. * [AD-876] Code review improvements comments/data types/documentation. * Update src/odbc-test/src/api_robustness_test.cpp Co-authored-by: Alina (Xi) Li <[email protected]> Co-authored-by: Alina (Xi) Li <[email protected]>

[AD-909] Implement row_array_size statement attribute. Fix discovered…

31b4c04

… bugs.

Bruce Irschick added 5 commits August 30, 2022 15:02

[AD-909] Attempt to resolve MacOS test issues.

2fdb84d

[AD-909] Attempt to resolve MacOS test issues.

88dd04d

[AD-909] Attempt to resolve MacOS test issues.

db8a804

[AD-909] Fix compile error.

b5f7dbd

[AD-909] Clean-up code.

1ba389e

birschick-bq commented Aug 31, 2022

View reviewed changes

affonsov reviewed Aug 31, 2022

View reviewed changes

src/tests/performance/include/performance_test_runner.h Show resolved Hide resolved

[AD-876] Code review improvement to add ticket for performance tests.

e0034b9

affonsov approved these changes Sep 1, 2022

View reviewed changes

alinaliBQ suggested changes Sep 2, 2022

View reviewed changes

[AD-876] Code review improvements comments/data types/documentation.

e6d3d37

birschick-bq requested a review from alinaliBQ September 2, 2022 19:41

alinaliBQ reviewed Sep 2, 2022

View reviewed changes

src/odbc-test/src/api_robustness_test.cpp Outdated Show resolved Hide resolved

Update src/odbc-test/src/api_robustness_test.cpp

6a4a69f

Co-authored-by: Alina (Xi) Li <[email protected]>

alinaliBQ approved these changes Sep 2, 2022

View reviewed changes

birschick-bq merged commit fa77c09 into develop Sep 2, 2022

birschick-bq deleted the birschick-bq/ad-876/impl-row-array_size branch September 2, 2022 21:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AD-909] Enable SQL_ATTR_ROW_ARRAY_SIZE statement attribute greater than 1. #114

[AD-909] Enable SQL_ATTR_ROW_ARRAY_SIZE statement attribute greater than 1. #114

birschick-bq commented Aug 30, 2022 •

edited

Loading

github-actions bot commented Aug 30, 2022 •

edited

Loading

github-actions bot commented Aug 30, 2022 •

edited

Loading

github-actions bot commented Aug 30, 2022 •

edited

Loading

github-actions bot commented Aug 30, 2022 •

edited

Loading

affonsov left a comment

birschick-bq commented Sep 1, 2022 •

edited

Loading

github-actions bot commented Sep 2, 2022

github-actions bot commented Sep 2, 2022

github-actions bot commented Sep 2, 2022

[AD-909] Enable SQL_ATTR_ROW_ARRAY_SIZE statement attribute greater than 1. #114

[AD-909] Enable SQL_ATTR_ROW_ARRAY_SIZE statement attribute greater than 1. #114

Conversation

birschick-bq commented Aug 30, 2022 • edited Loading

Summary

Description

Related Issue

Additional Reviewers

github-actions bot commented Aug 30, 2022 • edited Loading

Windows 2022 (x32) Build Unit Test Results

github-actions bot commented Aug 30, 2022 • edited Loading

MacOS Big Sur 11 Debug Build Unit Test Results

github-actions bot commented Aug 30, 2022 • edited Loading

Windows 2022 (x64) Build Unit Test Results

github-actions bot commented Aug 30, 2022 • edited Loading

Ubuntu 20.04 Debug Build Unit Test Results

affonsov left a comment

Choose a reason for hiding this comment

birschick-bq commented Sep 1, 2022 • edited Loading

github-actions bot commented Sep 2, 2022

MacOS Big Sur 11 Debug Build Code Coverage Result

github-actions bot commented Sep 2, 2022

Ubuntu 20.04 Debug Build Unit Test Results Check

github-actions bot commented Sep 2, 2022

Windows 2022 (x32) Debug Build Unit Test Results Check

birschick-bq commented Aug 30, 2022 •

edited

Loading

github-actions bot commented Aug 30, 2022 •

edited

Loading

github-actions bot commented Aug 30, 2022 •

edited

Loading

github-actions bot commented Aug 30, 2022 •

edited

Loading

github-actions bot commented Aug 30, 2022 •

edited

Loading

birschick-bq commented Sep 1, 2022 •

edited

Loading