Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AD-845] User and auth are supported in SQLConnect #109

Merged
merged 14 commits into from
Aug 15, 2022
Merged

[AD-845] User and auth are supported in SQLConnect #109

merged 14 commits into from
Aug 15, 2022

Conversation

birschick-bq
Copy link
Contributor

Summary

[AD-845] User and auth are supported in SQLConnect

Description

Fully support SQLConnect with passed username and password.

Related Issue

https://bitquill.atlassian.net/browse/AD-845

Additional Reviewers

@affonsoBQ
@alexey-temnikov
@alinaliBQ
@andiem-bq
@birschick-bq
@mitchell-elholm
@RoyZhang2022

@github-actions
Copy link

github-actions bot commented Aug 9, 2022 •
edited
Loading

Ubuntu 20.04 Debug Build Unit Test Results

    1 files  ±0      1 suites  ±0   30s ⏱️ -2s
271 tests +5  259 ✔️ +5  12 💤 ±0  0 ❌ ±0 
259 runs  +5  259 ✔️ +5    0 💤 ±0  0 ❌ ±0 

Results for commit d201c2f. ± Comparison against base commit f287d53.

This pull request removes 5 and adds 10 tests. Note that renamed tests count towards both. 
ConnectionTestSuite ‑ TestConnectionIncompleteBasicProperties
ConnectionTestSuite ‑ TestConnectionIncompleteSSHTunnelProperties
ConnectionTestSuite ‑ TestConnectionInvalidUser
ConnectionTestSuite ‑ TestConnectionRestoreLocalServer
ConnectionTestSuite ‑ TestConnectionRestoreMiscOptionsSet

ConnectionTestSuite.TestConnectionIncompleteBasicProperties ‑ _0
ConnectionTestSuite.TestConnectionIncompleteBasicProperties ‑ _1
ConnectionTestSuite.TestConnectionIncompleteSSHTunnelProperties ‑ _0
ConnectionTestSuite.TestConnectionIncompleteSSHTunnelProperties ‑ _1
ConnectionTestSuite.TestConnectionInvalidUser ‑ _0
ConnectionTestSuite.TestConnectionInvalidUser ‑ _1
ConnectionTestSuite.TestConnectionRestoreLocalServer ‑ _0
ConnectionTestSuite.TestConnectionRestoreLocalServer ‑ _1
ConnectionTestSuite.TestConnectionRestoreMiscOptionsSet ‑ _0
ConnectionTestSuite.TestConnectionRestoreMiscOptionsSet ‑ _1

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 9, 2022 •
edited
Loading

MacOS Big Sur 11 Debug Build Unit Test Results

    1 files  ±0      1 suites  ±0   45s ⏱️ -1s
268 tests +5  256 ✔️ +5  12 💤 ±0  0 ❌ ±0 
256 runs  +5  244 ✔️ +5  12 💤 ±0  0 ❌ ±0 

Results for commit d201c2f. ± Comparison against base commit f287d53.

This pull request removes 5 and adds 10 tests. Note that renamed tests count towards both. 
ConnectionTestSuite ‑ TestConnectionIncompleteBasicProperties
ConnectionTestSuite ‑ TestConnectionIncompleteSSHTunnelProperties
ConnectionTestSuite ‑ TestConnectionInvalidUser
ConnectionTestSuite ‑ TestConnectionRestoreLocalServer
ConnectionTestSuite ‑ TestConnectionRestoreMiscOptionsSet

ConnectionTestSuite.TestConnectionIncompleteBasicProperties ‑ _0
ConnectionTestSuite.TestConnectionIncompleteBasicProperties ‑ _1
ConnectionTestSuite.TestConnectionIncompleteSSHTunnelProperties ‑ _0
ConnectionTestSuite.TestConnectionIncompleteSSHTunnelProperties ‑ _1
ConnectionTestSuite.TestConnectionInvalidUser ‑ _0
ConnectionTestSuite.TestConnectionInvalidUser ‑ _1
ConnectionTestSuite.TestConnectionRestoreLocalServer ‑ _0
ConnectionTestSuite.TestConnectionRestoreLocalServer ‑ _1
ConnectionTestSuite.TestConnectionRestoreMiscOptionsSet ‑ _0
ConnectionTestSuite.TestConnectionRestoreMiscOptionsSet ‑ _1

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 9, 2022 •
edited
Loading

Windows 2022 (x64) Build Unit Test Results

    1 files  ±0      1 suites  ±0   1m 12s ⏱️ +4s
271 tests +5  259 ✔️ +5  12 💤 ±0  0 ❌ ±0 
259 runs  +5  247 ✔️ +5  12 💤 ±0  0 ❌ ±0 

Results for commit d201c2f. ± Comparison against base commit f287d53.

This pull request removes 5 and adds 10 tests. Note that renamed tests count towards both. 
ConnectionTestSuite ‑ TestConnectionIncompleteBasicProperties
ConnectionTestSuite ‑ TestConnectionIncompleteSSHTunnelProperties
ConnectionTestSuite ‑ TestConnectionInvalidUser
ConnectionTestSuite ‑ TestConnectionRestoreLocalServer
ConnectionTestSuite ‑ TestConnectionRestoreMiscOptionsSet

ConnectionTestSuite.TestConnectionIncompleteBasicProperties ‑ _0
ConnectionTestSuite.TestConnectionIncompleteBasicProperties ‑ _1
ConnectionTestSuite.TestConnectionIncompleteSSHTunnelProperties ‑ _0
ConnectionTestSuite.TestConnectionIncompleteSSHTunnelProperties ‑ _1
ConnectionTestSuite.TestConnectionInvalidUser ‑ _0
ConnectionTestSuite.TestConnectionInvalidUser ‑ _1
ConnectionTestSuite.TestConnectionRestoreLocalServer ‑ _0
ConnectionTestSuite.TestConnectionRestoreLocalServer ‑ _1
ConnectionTestSuite.TestConnectionRestoreMiscOptionsSet ‑ _0
ConnectionTestSuite.TestConnectionRestoreMiscOptionsSet ‑ _1

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 9, 2022 •
edited
Loading

Windows 2022 (x32) Build Unit Test Results

    1 files  ±0      1 suites  ±0   1m 4s ⏱️ -5s
271 tests +5  259 ✔️ +5  12 💤 ±0  0 ❌ ±0 
259 runs  +5  247 ✔️ +5  12 💤 ±0  0 ❌ ±0 

Results for commit d201c2f. ± Comparison against base commit f287d53.

This pull request removes 5 and adds 10 tests. Note that renamed tests count towards both. 
ConnectionTestSuite ‑ TestConnectionIncompleteBasicProperties
ConnectionTestSuite ‑ TestConnectionIncompleteSSHTunnelProperties
ConnectionTestSuite ‑ TestConnectionInvalidUser
ConnectionTestSuite ‑ TestConnectionRestoreLocalServer
ConnectionTestSuite ‑ TestConnectionRestoreMiscOptionsSet

ConnectionTestSuite.TestConnectionIncompleteBasicProperties ‑ _0
ConnectionTestSuite.TestConnectionIncompleteBasicProperties ‑ _1
ConnectionTestSuite.TestConnectionIncompleteSSHTunnelProperties ‑ _0
ConnectionTestSuite.TestConnectionIncompleteSSHTunnelProperties ‑ _1
ConnectionTestSuite.TestConnectionInvalidUser ‑ _0
ConnectionTestSuite.TestConnectionInvalidUser ‑ _1
ConnectionTestSuite.TestConnectionRestoreLocalServer ‑ _0
ConnectionTestSuite.TestConnectionRestoreLocalServer ‑ _1
ConnectionTestSuite.TestConnectionRestoreMiscOptionsSet ‑ _0
ConnectionTestSuite.TestConnectionRestoreMiscOptionsSet ‑ _1

♻️ This comment has been updated with latest results.

@birschick-bq birschick-bq changed the title [AD-845] User and auth are supported in SQLConnect [AD-845] DRAFT: User and auth are supported in SQLConnect Aug 9, 2022
@birschick-bq birschick-bq changed the title [AD-845] DRAFT: User and auth are supported in SQLConnect [AD-845] User and auth are supported in SQLConnect Aug 10, 2022
alinaliBQ
alinaliBQ reviewed Aug 10, 2022
View reviewed changes
src/odbc-test/src/odbc_test_suite.cpp Outdated Show resolved Hide resolved
src/odbc-test/src/odbc_test_suite.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

MacOS Big Sur 11 Debug Build Code Coverage Result

Code Coverage

Package Line Rate Branch Rate Complexity Health
src.odbc.include.documentdb.odbc 29% 37% 0 ❌
src.odbc.include.documentdb.odbc.app 20% 0% 0 ❌
src.odbc.include.documentdb.odbc.binary 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.cache.query 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.cluster 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.common 13% 11% 0 ❌
src.odbc.include.documentdb.odbc.compute 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.config 86% 50% 0 ✔
src.odbc.include.documentdb.odbc.diagnostic 86% 50% 0 ✔
src.odbc.include.documentdb.odbc.impl 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.impl.binary 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.impl.cache 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.impl.cache.query 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.impl.cache.query.continuous 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.impl.compute 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.impl.interop 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.jni 48% 40% 0 ❌
src.odbc.include.documentdb.odbc.meta 47% 50% 0 ❌
src.odbc.include.documentdb.odbc.query 15% 0% 0 ❌
src.odbc.include.documentdb.odbc.sql 11% 0% 0 ❌
src.odbc.include.documentdb.odbc.streaming 0% 0% 0 ❌
src.odbc.os.linux.include.documentdb.odbc.common 0% 0% 0 ❌
src.odbc.os.linux.src.common 34% 35% 0 ❌
src.odbc.src 48% 28% 0 ❌
src.odbc.src.app 16% 3% 0 ❌
src.odbc.src.binary 0% 0% 0 ❌
src.odbc.src.cluster 2% 0% 0 ❌
src.odbc.src.common 22% 10% 0 ❌
src.odbc.src.config 70% 44% 0 ➖
src.odbc.src.diagnostic 44% 20% 0 ❌
src.odbc.src.impl 1% 0% 0 ❌
src.odbc.src.impl.binary 0% 0% 0 ❌
src.odbc.src.impl.cache 2% 0% 0 ❌
src.odbc.src.impl.cache.query 1% 0% 0 ❌
src.odbc.src.impl.cache.query.continuous 0% 0% 0 ❌
src.odbc.src.impl.cluster 2% 0% 0 ❌
src.odbc.src.impl.compute 0% 0% 0 ❌
src.odbc.src.impl.interop 1% 0% 0 ❌
src.odbc.src.jni 66% 26% 0 ➖
src.odbc.src.jni.os.linux 46% 23% 0 ❌
src.odbc.src.meta 89% 54% 0 ✔
src.odbc.src.query 63% 27% 0 ➖
src.odbc.src.sql 25% 9% 0 ❌
src.odbc.src.streaming 3% 0% 0 ❌
Summary 37% (5928 / 16181) 23% (9382 / 41467) 0 ❌

@github-actions
Copy link

Ubuntu 20.04 Debug Build Unit Test Results Check

Code Coverage

Package Line Rate Branch Rate Complexity Health
src.odbc.include.documentdb.odbc 41% 39% 0 ❌
src.odbc.include.documentdb.odbc.app 45% 0% 0 ❌
src.odbc.include.documentdb.odbc.binary 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.cache.query 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.common 61% 34% 0 ➖
src.odbc.include.documentdb.odbc.compute 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.config 100% 50% 0 ✔
src.odbc.include.documentdb.odbc.diagnostic 82% 50% 0 ✔
src.odbc.include.documentdb.odbc.impl 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.impl.binary 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.impl.cache.query 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.impl.cache.query.continuous 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.impl.compute 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.impl.interop 0% 0% 0 ❌
src.odbc.include.documentdb.odbc.jni 77% 39% 0 ✔
src.odbc.include.documentdb.odbc.meta 71% 50% 0 ➖
src.odbc.include.documentdb.odbc.query 20% 0% 0 ❌
src.odbc.include.documentdb.odbc.sql 50% 11% 0 ➖
src.odbc.include.documentdb.odbc.streaming 0% 0% 0 ❌
src.odbc.os.linux.include.documentdb.odbc.common 0% 0% 0 ❌
src.odbc.os.linux.src.common 34% 42% 0 ❌
src.odbc.src 46% 28% 0 ❌
src.odbc.src.app 25% 13% 0 ❌
src.odbc.src.binary 0% 0% 0 ❌
src.odbc.src.cluster 0% 0% 0 ❌
src.odbc.src.common 28% 17% 0 ❌
src.odbc.src.config 70% 44% 0 ➖
src.odbc.src.diagnostic 32% 15% 0 ❌
src.odbc.src.impl 0% 0% 0 ❌
src.odbc.src.impl.binary 0% 0% 0 ❌
src.odbc.src.impl.cache 0% 0% 0 ❌
src.odbc.src.impl.cache.query 0% 0% 0 ❌
src.odbc.src.impl.cache.query.continuous 0% 0% 0 ❌
src.odbc.src.impl.cluster 0% 0% 0 ❌
src.odbc.src.impl.compute 0% 0% 0 ❌
src.odbc.src.impl.interop 0% 0% 0 ❌
src.odbc.src.jni 63% 27% 0 ➖
src.odbc.src.jni.os.linux 38% 20% 0 ❌
src.odbc.src.meta 88% 54% 0 ✔
src.odbc.src.query 59% 27% 0 ➖
src.odbc.src.sql 18% 8% 0 ❌
src.odbc.src.streaming 0% 0% 0 ❌
Summary 37% (5858 / 15765) 25% (9017 / 36656) 0 ❌

@github-actions
Copy link

Windows 2022 (x32) Debug Build Unit Test Results Check

Code Coverage

Package Line Rate Branch Rate Complexity Health
D:\a\amazon-documentdb-odbc-driver\amazon-documentdb-odbc-driver\build\odbc\bin\Debug\documentdb.odbc.dll 34% 0% 0 ❌
Summary 34% (6846 / 20033) 0% (0 / 0) 0 ❌

alinaliBQ
alinaliBQ approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@alinaliBQ alinaliBQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@birschick-bq birschick-bq merged commit 5690962 into develop Aug 15, 2022
@birschick-bq birschick-bq deleted the birschick-bq/ad-845/sql-connect branch August 15, 2022 17:22
affonsov pushed a commit that referenced this pull request Nov 16, 2022
[AD-845] User and auth are supported in SQLConnect (#109)
7dbecc6 
* [AD-845] Update user and password if passed to SQLConnect.

* [AD-845] Add tests for SQLConnect.

* [AD-845] Refactor Windows-specific code.

* [AD-845] Attempt to resolve MacOS test error for writing to ODBC.INI

* [AD-845] Attempt to resolve MacOS test error for writing to ODBC.INI

* [AD-845] Fix Linux ODBC compile error.

* [AD-845] Fix MacOS ODBC compile error.

* [AD-845] Attempt to resolve Linux test error for writing to ODBC.INI

* [AD-845] Attempt to resolve Linux test error for prefixed text in error message.

* [AD-845] Refactor location to ODBC.INI

* [AD-845] Attempt to resolve MacOS test error for writing to ODBC.INI

* [AD-845] Code review suggestions.
affonsov pushed a commit that referenced this pull request Nov 17, 2022
[AD-845] User and auth are supported in SQLConnect (#109)
5646eda 
* [AD-845] Update user and password if passed to SQLConnect.

* [AD-845] Add tests for SQLConnect.

* [AD-845] Refactor Windows-specific code.

* [AD-845] Attempt to resolve MacOS test error for writing to ODBC.INI

* [AD-845] Attempt to resolve MacOS test error for writing to ODBC.INI

* [AD-845] Fix Linux ODBC compile error.

* [AD-845] Fix MacOS ODBC compile error.

* [AD-845] Attempt to resolve Linux test error for writing to ODBC.INI

* [AD-845] Attempt to resolve Linux test error for prefixed text in error message.

* [AD-845] Refactor location to ODBC.INI

* [AD-845] Attempt to resolve MacOS test error for writing to ODBC.INI

* [AD-845] Code review suggestions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinaliBQ alinaliBQ alinaliBQ approved these changes

@affonsov affonsov affonsov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@birschick-bq @affonsov @alinaliBQ