Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FLB_ERROR from flush to ensure there is never log loss #315

Merged
merged 3 commits into from
Mar 7, 2023

Conversation

PettitWesley
Copy link
Contributor

Issue #, if available:

#314

Description of changes:

all failures are retryable

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@PettitWesley PettitWesley requested a review from a team as a code owner March 7, 2023 03:00
Signed-off-by: Wesley Pettit <[email protected]>
Copy link
Contributor

@matthewfala matthewfala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

@PettitWesley PettitWesley merged commit 0d5974a into aws:mainline Mar 7, 2023
@PettitWesley PettitWesley deleted the never-use-flb-error branch March 7, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants