Add source node to audio graph for silent devices #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XHatan
reviewed
Dec 18, 2019
| @@ -249,14 +249,15 @@ export default class DefaultDeviceController implements DeviceControllerBasedMed | |||
| static synthesizeAudioDevice(toneHz: number): Device { | |||
| const audioContext = DefaultDeviceController.createAudioContext(); | |||
| const outputNode = audioContext.createMediaStreamDestination(); | |||
| const gainNode = audioContext.createGain(); | |||
| gainNode.gain.value = 0.0; | |||
| gainNode.connect(outputNode); | |||
There was a problem hiding this comment.
Should this gainNode.connect(outputNode) be executed after the following if or it does not matter ?
There was a problem hiding this comment.
It doesn't matter. It just needs to get hooked up to the outputNode. If using a tone generator then that will then get hitched to the gainNode in the if-block.
XHatan
approved these changes
Dec 18, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add source node to audio graph for silent devices. Without a source node, the WebAudio MediaStreamDestination will not actually contain any audio. The server will not show the attendee as present unless audio data is received. To fix, it is enough to have a gain node attached to the MediaStreamDestinationNode with no input of its own and a gain of 0.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.