Fix #3 - Safari crashes when remote video tiles are added or toggled #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justindarc
changed the title
justindarc
changed the title
justindarc
changed the title
justindarc
force-pushed
the
fix-safari-crash
branch
2 times, most recently
from
96a586a to
8e511bc
Compare
justindarc
force-pushed
the
fix-safari-crash
branch
from
8e511bc to
9087b5c
Compare
andi-amzn
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where Safari may crash and reload the page when remote video tiles are added or toggled.
Previously, when cleaning up a video tile, we would simply set
videoElement.srcObject = nullto end theMediaStream. However, this seems to invoke a crash in Safari where internally aNULLpointer is referenced. The solution is to remove all tracks from the<video>element'sMediaStreambefore waiting until the next frame to setvideoElement.srcObject = null.