Revert "Ensure that screen connection is made only on view request"

This reverts commit b440283.

src/screenshareviewfacade/DefaultScreenShareViewFacade.ts

@@ -45,24 +45,26 @@ export default class DefaultScreenShareViewFacade implements ScreenShareViewFaca
     );
   }
 
-  async open(): Promise<void> {}
-
-  async close(): Promise<void> {}
-
-  async start(element: HTMLDivElement): Promise<void> {
+  async open(): Promise<void> {
     const connectionRequest: ScreenViewingSessionConnectionRequest = new ScreenViewingSessionConnectionRequest(
       this.configuration.urls.screenViewingURL,
       this.configuration.urls.screenDataURL,
       this.configuration.credentials.joinToken,
       this.configuration.screenViewingTimeoutMs
     );
     await this.screenViewing.open(connectionRequest);
+  }
+
+  async close(): Promise<void> {
+    await this.screenViewing.close();
+  }
+
+  start(element: HTMLDivElement): void {
     return this.screenViewing.start(element);
   }
 
-  async stop(): Promise<void> {
+  stop(): void {
     this.screenViewing.stop();
-    await this.screenViewing.close();
   }
 
   presentScaleToFit(): void {

src/screenshareviewfacade/ScreenShareViewFacade.ts

@@ -6,28 +6,24 @@ import ScreenObserver from '../screenviewing/observer/ScreenObserver';
 export default interface ScreenShareViewFacade {
   /**
    * Opens the connections, must be called after the ScreenShareViewFacade is constructed
-   *
-   * @deprecated Use start when the user wants to start viewing screen
    */
   open(): Promise<void>;
 
   /**
    * Closes screen viewing connection
-   *
-   * @deprecated Use stop when the user wants to stop viewing screen
    */
   close(): Promise<void>;
 
   /**
    * Starts viewing the screen share within an HTML element. Note that an
    * HTMLCanvas will be placed inside of this element.
    */
-  start(element: HTMLDivElement): Promise<void>;
+  start(element: HTMLDivElement): void;
 
   /**
    * Stops viewing the screen share.
    */
-  stop(): Promise<void>;
+  stop(): void;
 
   /**
    * Changes the presentation policy to scale-to-fit