Remove Demo feature HTMLSelectElement multiple attribute

aws · Jun 29, 2020 · 457f6a2 · 457f6a2
1 parent 7d31654
commit 457f6a2
Show file tree

Hide file tree

Showing 8 changed files with 20 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 ### Removed
+- Remove browser demo optional feature HTMLSelectElement multiple attribute
 
 ### Fixed
 - Fix CloudWatch metrics for Linux and Android integration tests

diff --git a/demos/browser/app/meeting/meeting.html b/demos/browser/app/meeting/meeting.html
@@ -45,10 +45,11 @@ <h1 class="h3 mb-3 font-weight-normal">Join a meeting</h1>
           <div class="row mt-3">
             <div class="col-12">
               <label for="optional-features">Optional Features</label>
-              <select id="optional-features" class="custom-select" style="width:100%" multiple>
-                <option value="">--Please choose an option--</option>
+              <select id="optional-features" class="custom-select" style="width:100%">
+                <option value="" selected>None</option>
                 <option value="simulcast">Enable Simulcast For Chrome</option>
                 <option value="webaudio">Use WebAudio</option>
+                <option value="unifiedplan">Use Unified Plan for Chrome</option>
               </select>
             </div>
           </div>

diff --git a/demos/browser/app/meeting/meeting.ts b/demos/browser/app/meeting/meeting.ts
@@ -299,14 +299,17 @@ export class DemoMeetingApp implements AudioVideoObserver, DeviceChangeObserver
       const collections = optionalFeatures.selectedOptions;
       this.enableSimulcast = false;
       this.enableWebAudio = false;
+      this.enableUnifiedPlanForChromiumBasedBrowsers = false;
       for (let i = 0; i < collections.length; i++) {
         // hard code magic
         if (collections[i].label === 'simulcast') {
           this.enableSimulcast = true;
           this.enableUnifiedPlanForChromiumBasedBrowsers = true;
-        } else if (collections[i].label === 'webaudio') {
+        }
+        if (collections[i].label === 'webaudio') {
           this.enableWebAudio = true;
-        } else if (collections[i].label === 'unifiedplan') {
+        }
+        if (collections[i].label === 'unifiedplan') {
           this.enableUnifiedPlanForChromiumBasedBrowsers = true;
         }
       }

diff --git a/demos/browser/app/meetingV2/meetingV2.html b/demos/browser/app/meetingV2/meetingV2.html
@@ -45,10 +45,11 @@ <h1 class="h3 mb-3 font-weight-normal">Join a meeting</h1>
       <div class="row mt-3">
         <div class="col-12">
           <label for="optional-features">Optional Features</label>
-          <select id="optional-features" class="custom-select" style="width:100%" multiple>
-            <option value="">--Please choose an option--</option>
+          <select id="optional-features" class="custom-select" style="width:100%">
+            <option value="" selected>None</option>
             <option value="simulcast">Enable Simulcast For Chrome</option>
             <option value="webaudio">Use WebAudio</option>
+            <option value="unifiedplan">Use Unified Plan For Chrome</option>
           </select>
         </div>
       </div>

diff --git a/demos/browser/app/meetingV2/meetingV2.ts b/demos/browser/app/meetingV2/meetingV2.ts
@@ -314,17 +314,20 @@ export class DemoMeetingApp implements AudioVideoObserver, DeviceChangeObserver,
       const collections = optionalFeatures.selectedOptions;
       this.enableSimulcast = false;
       this.enableWebAudio = false;
+      this.enableUnifiedPlanForChromiumBasedBrowsers = false;
       this.log("Feature lists:");
       for (let i = 0; i < collections.length; i++) {
         // hard code magic
         if (collections[i].value === 'simulcast') {
           this.enableSimulcast = true;
           this.enableUnifiedPlanForChromiumBasedBrowsers = true;
           this.log('attempt to enable simulcast');
-        } else if (collections[i].value === 'webaudio') {
+        }
+        if (collections[i].value === 'webaudio') {
           this.enableWebAudio = true;
           this.log('attempt to enable webaudio');
-        } else if (collections[i].value === 'unifiedplan') {
+        }
+        if (collections[i].value === 'unifiedplan') {
           this.enableUnifiedPlanForChromiumBasedBrowsers = true;
           this.log('attempt to enable unified plan');
         }

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "amazon-chime-sdk-js",
-  "version": "1.10.7",
+  "version": "1.10.8",
   "description": "Amazon Chime SDK for JavaScript",
   "main": "build/index.js",
   "types": "build/index.d.ts",

diff --git a/src/versioning/Versioning.ts b/src/versioning/Versioning.ts
@@ -18,7 +18,7 @@ export default class Versioning {
    * Return string representation of SDK version
    */
   static get sdkVersion(): string {
-    return '1.10.7';
+    return '1.10.8';
   }
 
   /**