Use pass in logger for ml modules #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltrung
reviewed
Nov 7, 2024
| const logger = | ||
| options?.logger || | ||
| new ConsoleLogger('BackgroundBlurProvider', LogLevel.INFO); | ||
| const optionsLogger = options?.logger || logger; |
There was a problem hiding this comment.
This is after the initialize right? We pass the logger to DefaultVideoTransformDevice
ltrung
reviewed
Nov 7, 2024
| @@ -51,7 +49,8 @@ export const BackgroundBlurProvider: FC<React.PropsWithChildren<Props>> = ({ | |||
| options, | |||
| children, | |||
| }) => { | |||
| const logger = useLogger(); | |||
| let logger = useLogger(); | |||
| logger = options?.logger || logger; | |||
There was a problem hiding this comment.
Why not just one line let logger = options?.logger || useLogger() ?
There was a problem hiding this comment.
there's warning for conditionally calling hooks
There was a problem hiding this comment.
how about const logger = options?.logger ?? useLogger() ?
xuesichao
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
Description of changes:
Default to logger from logger provider when initiate bgBlur, bgReplacement processors
Testing
Have you successfully run
npm run build:releaselocally? yesHow did you test these changes? Test using react meeting demo
If you made changes to the component library, have you provided corresponding documentation changes?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.