Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotation support #27

Closed
wants to merge 1 commit into from
Closed

Rotation support #27

wants to merge 1 commit into from

Conversation

rromanchuk
Copy link

Rotation support via metadata override. Backwards compatible as leaves DEGREE_0 as default, which is current behavior

This requires #23 to actually work (well, for any metadata override besides

…s DEGREE_0 as default, which is current behavior
@@ -72,7 +72,8 @@ The only required field for the metadata file is the srcVideo and the workflow w
"MediaConvert_Template_2160p":"string",
"MediaConvert_Template_1080p":"string",
"MediaConvert_Template_720p":"string",
"JobTemplate":"custom-job-template"
"JobTemplate":"custom-job-template",
"InputRotate": "DEGREE_0"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.aws.amazon.com/mediaconvert/latest/apireference/jobs.html#jobs-model-inputrotate

Should also probably mention using anything but default is going to cause the profiler to possibly select the wrong encoding profile as it's pixel math will be utilizing the pre-rotated dimensions.

For example, all ios videos record portrait (without the developer normalizing) videos with ROTATE 90, if AUTO were to be selected, without overriding the JobTemplate, the profiler doesn't know what the final dimensions after rotation may be.

If you know you have 16:9 portrait videos with ROTATION 90, you will need to intervene to help profiler out

if (event.srcWidth > event.srcHeight) {
      console.log('This video is most likely going to get rotated, swap width/height')
      event.srcWidth = mediaInfo.video[0].height;
      event.srcHeight = mediaInfo.video[0].width;
 }

@@ -9,9 +9,10 @@
"scripts": {
"test": "mocha lib/*.spec.js"
},
"dependencies": {},
"dependencies": {
"aws-sdk": "^2.414.0"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new Rotate is a new VideoSelector key, and this will fail without using the latest version of MediaConvert

@hnishar
Copy link

hnishar commented Mar 13, 2019

Thanks for opening a pull-request ticket. We will review the requests to be implemented in our next release.

@dscpinheiro
Copy link

Hi @rromanchuk,

We just released a new version of the solution (v5.0.0 - https://aws.amazon.com/solutions/video-on-demand-on-aws/), and support for the InputRotate parameter has been included.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants